From: Stefano Stabellini <sstabellini@kernel.org>
To: aneesh.kumar@linux.vnet.ibm.com
Cc: groug@kaod.org, sstabellini@kernel.org, qemu-devel@nongnu.org,
xen-devel@lists.xensource.com, anthony.perard@citrix.com,
wei.liu2@citrix.com
Subject: [Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu
Date: Mon, 21 Nov 2016 13:39:32 -0800 [thread overview]
Message-ID: <1479764372-29470-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1479764372-29470-1-git-send-email-sstabellini@kernel.org>
Not all 9pfs transports share memory between request and response. For
those who don't, it is necessary to know how much memory is required in
the response.
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
---
hw/9pfs/9p.c | 2 +-
hw/9pfs/9p.h | 2 +-
hw/9pfs/virtio-9p-device.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index b6ec042..b82212b 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1652,7 +1652,7 @@ static void v9fs_init_qiov_from_pdu(QEMUIOVector *qiov, V9fsPDU *pdu,
struct iovec *iov;
unsigned int niov;
- pdu->s->transport->init_iov_from_pdu(pdu, &iov, &niov, is_write);
+ pdu->s->transport->init_iov_from_pdu(pdu, &iov, &niov, is_write, skip + size);
qemu_iovec_init_external(&elem, iov, niov);
qemu_iovec_init(qiov, niov);
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index ab398d0..c830188 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -348,7 +348,7 @@ struct V9fsTransport {
ssize_t (*pdu_vmarshal)(V9fsPDU *pdu, size_t offset, const char *fmt, va_list ap);
ssize_t (*pdu_vunmarshal)(V9fsPDU *pdu, size_t offset, const char *fmt, va_list ap);
void (*init_iov_from_pdu)(V9fsPDU *pdu, struct iovec **piov,
- unsigned int *pniov, bool is_write);
+ unsigned int *pniov, bool is_write, size_t size);
void (*push_and_notify)(V9fsPDU *pdu);
};
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index e1a37a4..e2b27e8 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -172,7 +172,7 @@ static ssize_t virtio_pdu_vunmarshal(V9fsPDU *pdu, size_t offset,
}
static void virtio_init_iov_from_pdu(V9fsPDU *pdu, struct iovec **piov,
- unsigned int *pniov, bool is_write)
+ unsigned int *pniov, bool is_write, size_t size)
{
V9fsState *s = pdu->s;
V9fsVirtioState *v = container_of(s, V9fsVirtioState, state);
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: aneesh.kumar@linux.vnet.ibm.com
Cc: xen-devel@lists.xensource.com, wei.liu2@citrix.com,
groug@kaod.org, qemu-devel@nongnu.org, sstabellini@kernel.org,
anthony.perard@citrix.com
Subject: [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu
Date: Mon, 21 Nov 2016 13:39:32 -0800 [thread overview]
Message-ID: <1479764372-29470-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1479764372-29470-1-git-send-email-sstabellini@kernel.org>
Not all 9pfs transports share memory between request and response. For
those who don't, it is necessary to know how much memory is required in
the response.
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
---
hw/9pfs/9p.c | 2 +-
hw/9pfs/9p.h | 2 +-
hw/9pfs/virtio-9p-device.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index b6ec042..b82212b 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1652,7 +1652,7 @@ static void v9fs_init_qiov_from_pdu(QEMUIOVector *qiov, V9fsPDU *pdu,
struct iovec *iov;
unsigned int niov;
- pdu->s->transport->init_iov_from_pdu(pdu, &iov, &niov, is_write);
+ pdu->s->transport->init_iov_from_pdu(pdu, &iov, &niov, is_write, skip + size);
qemu_iovec_init_external(&elem, iov, niov);
qemu_iovec_init(qiov, niov);
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index ab398d0..c830188 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -348,7 +348,7 @@ struct V9fsTransport {
ssize_t (*pdu_vmarshal)(V9fsPDU *pdu, size_t offset, const char *fmt, va_list ap);
ssize_t (*pdu_vunmarshal)(V9fsPDU *pdu, size_t offset, const char *fmt, va_list ap);
void (*init_iov_from_pdu)(V9fsPDU *pdu, struct iovec **piov,
- unsigned int *pniov, bool is_write);
+ unsigned int *pniov, bool is_write, size_t size);
void (*push_and_notify)(V9fsPDU *pdu);
};
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index e1a37a4..e2b27e8 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -172,7 +172,7 @@ static ssize_t virtio_pdu_vunmarshal(V9fsPDU *pdu, size_t offset,
}
static void virtio_init_iov_from_pdu(V9fsPDU *pdu, struct iovec **piov,
- unsigned int *pniov, bool is_write)
+ unsigned int *pniov, bool is_write, size_t size)
{
V9fsState *s = pdu->s;
V9fsVirtioState *v = container_of(s, V9fsVirtioState, state);
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-21 21:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 21:39 [Qemu-devel] [PATCH 0/4] 9pfs: clean-up for multiple transports Stefano Stabellini
2016-11-21 21:39 ` Stefano Stabellini
2016-11-21 21:39 ` [Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState Stefano Stabellini
2016-11-21 21:39 ` Stefano Stabellini
2016-11-21 21:39 ` [Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks Stefano Stabellini
2016-11-21 21:39 ` Stefano Stabellini
2016-11-24 8:31 ` [Qemu-devel] " Greg Kurz
2016-11-24 8:31 ` Greg Kurz
2016-11-24 14:23 ` [Qemu-devel] " Greg Kurz
2016-11-24 14:23 ` Greg Kurz
2016-11-24 14:43 ` Greg Kurz
2016-11-24 14:43 ` Greg Kurz
2016-11-28 20:12 ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2016-11-28 20:12 ` [Qemu-devel] " Stefano Stabellini
2016-11-28 20:11 ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2016-11-28 20:11 ` [Qemu-devel] " Stefano Stabellini
2016-11-21 21:39 ` [Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack Stefano Stabellini
2016-11-21 21:39 ` Stefano Stabellini
2016-11-24 14:48 ` [Qemu-devel] " Greg Kurz
2016-11-24 14:48 ` Greg Kurz
2016-11-28 20:35 ` [Qemu-devel] " Stefano Stabellini
2016-11-28 20:35 ` Stefano Stabellini
2016-11-21 21:39 ` Stefano Stabellini [this message]
2016-11-21 21:39 ` [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu Stefano Stabellini
2016-11-24 16:17 ` [Qemu-devel] " Greg Kurz
2016-11-24 16:17 ` Greg Kurz
2016-11-28 21:21 ` [Qemu-devel] " Stefano Stabellini
2016-11-28 21:21 ` Stefano Stabellini
2016-11-24 8:30 ` [Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState Greg Kurz
2016-11-24 8:30 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479764372-29470-4-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.