From: Johannes Berg <johannes@sipsolutions.net>
To: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Maxim Altshul <maxim.altshul@ti.com>
Subject: Re: [PATCH] mac80211: Remove unused 'struct rate_control_ref' variable
Date: Tue, 22 Nov 2016 08:30:30 +0100 [thread overview]
Message-ID: <1479799830.4391.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20161122065416.GA3565@google.com> (sfid-20161122_075424_196465_55445AD4)
On Mon, 2016-11-21 at 22:54 -0800, Kirtika Ruchandani wrote:
> Commit 3b17fbf87d5d introduced sta_get_expected_throughput()
> leaving variable 'struct rate_control_ref* ref' set but unused.
> Compiling with W=1 gives the following warning, fix it.
>
> net/mac80211/sta_info.c: In function ‘sta_set_sinfo’:
> net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set but not
> used [-Wunused-but-set-variable]
Applied all three of these, thanks Kirtika.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Kirtika Ruchandani
<kirtika.ruchandani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Maxim Altshul <maxim.altshul-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] mac80211: Remove unused 'struct rate_control_ref' variable
Date: Tue, 22 Nov 2016 08:30:30 +0100 [thread overview]
Message-ID: <1479799830.4391.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20161122065416.GA3565-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> (sfid-20161122_075424_196465_55445AD4)
On Mon, 2016-11-21 at 22:54 -0800, Kirtika Ruchandani wrote:
> Commit 3b17fbf87d5d introduced sta_get_expected_throughput()
> leaving variable 'struct rate_control_ref* ref' set but unused.
> Compiling with W=1 gives the following warning, fix it.
>
> net/mac80211/sta_info.c: In function ‘sta_set_sinfo’:
> net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set but not
> used [-Wunused-but-set-variable]
Applied all three of these, thanks Kirtika.
johannes
next prev parent reply other threads:[~2016-11-22 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 6:54 [PATCH] mac80211: Remove unused 'struct rate_control_ref' variable Kirtika Ruchandani
2016-11-22 6:54 ` Kirtika Ruchandani
2016-11-22 7:30 ` Johannes Berg [this message]
2016-11-22 7:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479799830.4391.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=kirtika.ruchandani@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxim.altshul@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.