From: Lubomir Rintel <lkundrak@v3.sk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [patch] char/pcmcia: add some error checking in scr24x_read()
Date: Thu, 24 Nov 2016 10:48:01 +0000 [thread overview]
Message-ID: <1479984481.8204.0.camel@v3.sk> (raw)
In-Reply-To: <20161124104623.GA17225@mwanda>
On Thu, 2016-11-24 at 13:46 +0300, Dan Carpenter wrote:
> The "ret = " assignment seems to have accidentally been left off.
>
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce..8523ec5 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp,
> char __user *buf, size_t count,
> ret = -EIO;
> goto out;
> }
> - read_chunk(dev, CCID_HEADER_SIZE, len);
> + ret = read_chunk(dev, CCID_HEADER_SIZE, len);
> if (ret < 0)
> goto out;
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you,
Lubo
WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [patch] char/pcmcia: add some error checking in scr24x_read()
Date: Thu, 24 Nov 2016 11:48:01 +0100 [thread overview]
Message-ID: <1479984481.8204.0.camel@v3.sk> (raw)
In-Reply-To: <20161124104623.GA17225@mwanda>
On Thu, 2016-11-24 at 13:46 +0300, Dan Carpenter wrote:
> The "ret = " assignment seems to have accidentally been left off.
>
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce..8523ec5 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp,
> char __user *buf, size_t count,
> ret = -EIO;
> goto out;
> }
> - read_chunk(dev, CCID_HEADER_SIZE, len);
> + ret = read_chunk(dev, CCID_HEADER_SIZE, len);
> if (ret < 0)
> goto out;
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you,
Lubo
next prev parent reply other threads:[~2016-11-24 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 10:46 [patch] char/pcmcia: add some error checking in scr24x_read() Dan Carpenter
2016-11-24 10:46 ` Dan Carpenter
2016-11-24 10:48 ` Lubomir Rintel [this message]
2016-11-24 10:48 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479984481.8204.0.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.