From: Eric Biggers <ebiggers@google.com>
To: linux-ext4@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>,
Andreas Gruenbacher <agruenba@redhat.com>,
Eric Biggers <ebiggers@google.com>
Subject: [PATCH 2/5] mbcache: don't BUG() if entry cache cannot be allocated
Date: Sat, 26 Nov 2016 22:17:58 -0800 [thread overview]
Message-ID: <1480227481-98535-2-git-send-email-ebiggers@google.com> (raw)
In-Reply-To: <1480227481-98535-1-git-send-email-ebiggers@google.com>
mbcache can be a module that is loaded long after startup, when someone
asks to mount an ext2 or ext4 filesystem. Therefore it should not BUG()
if kmem_cache_create() fails, but rather just fail the module load.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/mbcache.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/mbcache.c b/fs/mbcache.c
index 31e54c2..c56ab21 100644
--- a/fs/mbcache.c
+++ b/fs/mbcache.c
@@ -420,7 +420,8 @@ static int __init mbcache_init(void)
mb_entry_cache = kmem_cache_create("mbcache",
sizeof(struct mb_cache_entry), 0,
SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD, NULL);
- BUG_ON(!mb_entry_cache);
+ if (!mb_entry_cache)
+ return -ENOMEM;
return 0;
}
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-11-27 6:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:17 [PATCH 1/5] mbcache: correctly handle 'e_referenced' bit Eric Biggers
2016-11-27 6:17 ` Eric Biggers [this message]
2016-11-28 12:09 ` [PATCH 2/5] mbcache: don't BUG() if entry cache cannot be allocated Jan Kara
2016-12-03 20:30 ` Theodore Ts'o
2016-11-27 6:17 ` [PATCH 3/5] mbcache: remove unnecessary module_get/module_put Eric Biggers
2016-11-28 13:12 ` Jan Kara
2016-12-03 20:41 ` Theodore Ts'o
2016-11-27 6:18 ` [PATCH 4/5] mbcache: use consistent type for entry count Eric Biggers
2016-11-28 13:18 ` Jan Kara
2016-12-03 20:54 ` Theodore Ts'o
2016-11-27 6:18 ` [PATCH 5/5] mbcache: document that "find" functions only return reusable entries Eric Biggers
2016-11-28 13:19 ` Jan Kara
2016-12-03 20:56 ` Theodore Ts'o
2016-11-28 10:44 ` [PATCH 1/5] mbcache: correctly handle 'e_referenced' bit Jan Kara
2016-11-28 17:32 ` Eric Biggers
2016-12-03 20:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480227481-98535-2-git-send-email-ebiggers@google.com \
--to=ebiggers@google.com \
--cc=agruenba@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.