From: Eric Biggers <ebiggers@google.com>
To: linux-ext4@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>,
Andreas Gruenbacher <agruenba@redhat.com>,
Eric Biggers <ebiggers@google.com>
Subject: [PATCH 5/5] mbcache: document that "find" functions only return reusable entries
Date: Sat, 26 Nov 2016 22:18:01 -0800 [thread overview]
Message-ID: <1480227481-98535-5-git-send-email-ebiggers@google.com> (raw)
In-Reply-To: <1480227481-98535-1-git-send-email-ebiggers@google.com>
mb_cache_entry_find_first() and mb_cache_entry_find_next() only return
cache entries with the 'e_reusable' bit set. This should be documented.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/mbcache.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/mbcache.c b/fs/mbcache.c
index bf65906..b19be42 100644
--- a/fs/mbcache.c
+++ b/fs/mbcache.c
@@ -155,12 +155,12 @@ static struct mb_cache_entry *__entry_find(struct mb_cache *cache,
}
/*
- * mb_cache_entry_find_first - find the first entry in cache with given key
+ * mb_cache_entry_find_first - find the first reusable entry with the given key
* @cache: cache where we should search
* @key: key to look for
*
- * Search in @cache for entry with key @key. Grabs reference to the first
- * entry found and returns the entry.
+ * Search in @cache for a reusable entry with key @key. Grabs reference to the
+ * first reusable entry found and returns the entry.
*/
struct mb_cache_entry *mb_cache_entry_find_first(struct mb_cache *cache,
u32 key)
@@ -170,14 +170,14 @@ struct mb_cache_entry *mb_cache_entry_find_first(struct mb_cache *cache,
EXPORT_SYMBOL(mb_cache_entry_find_first);
/*
- * mb_cache_entry_find_next - find next entry in cache with the same
+ * mb_cache_entry_find_next - find next reusable entry with the same key
* @cache: cache where we should search
* @entry: entry to start search from
*
- * Finds next entry in the hash chain which has the same key as @entry.
- * If @entry is unhashed (which can happen when deletion of entry races
- * with the search), finds the first entry in the hash chain. The function
- * drops reference to @entry and returns with a reference to the found entry.
+ * Finds next reusable entry in the hash chain which has the same key as @entry.
+ * If @entry is unhashed (which can happen when deletion of entry races with the
+ * search), finds the first reusable entry in the hash chain. The function drops
+ * reference to @entry and returns with a reference to the found entry.
*/
struct mb_cache_entry *mb_cache_entry_find_next(struct mb_cache *cache,
struct mb_cache_entry *entry)
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-11-27 6:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:17 [PATCH 1/5] mbcache: correctly handle 'e_referenced' bit Eric Biggers
2016-11-27 6:17 ` [PATCH 2/5] mbcache: don't BUG() if entry cache cannot be allocated Eric Biggers
2016-11-28 12:09 ` Jan Kara
2016-12-03 20:30 ` Theodore Ts'o
2016-11-27 6:17 ` [PATCH 3/5] mbcache: remove unnecessary module_get/module_put Eric Biggers
2016-11-28 13:12 ` Jan Kara
2016-12-03 20:41 ` Theodore Ts'o
2016-11-27 6:18 ` [PATCH 4/5] mbcache: use consistent type for entry count Eric Biggers
2016-11-28 13:18 ` Jan Kara
2016-12-03 20:54 ` Theodore Ts'o
2016-11-27 6:18 ` Eric Biggers [this message]
2016-11-28 13:19 ` [PATCH 5/5] mbcache: document that "find" functions only return reusable entries Jan Kara
2016-12-03 20:56 ` Theodore Ts'o
2016-11-28 10:44 ` [PATCH 1/5] mbcache: correctly handle 'e_referenced' bit Jan Kara
2016-11-28 17:32 ` Eric Biggers
2016-12-03 20:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480227481-98535-5-git-send-email-ebiggers@google.com \
--to=ebiggers@google.com \
--cc=agruenba@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.