[meta-swupd][PATCH] swupd-client: fix invalid directory in do_install_append()

[meta-swupd][PATCH] swupd-client: fix invalid directory in do_install_append()

[André Draszik]

From: André Draszik <adraszik@tycoint.com>

Signed-off-by: André Draszik <adraszik@tycoint.com>
---
 recipes-core/swupd-client/swupd-client_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-core/swupd-client/swupd-client_git.bb b/recipes-core/swupd-client/swupd-client_git.bb
index fd4716f..3aed480 100644
--- a/recipes-core/swupd-client/swupd-client_git.bb
+++ b/recipes-core/swupd-client/swupd-client_git.bb
@@ -38,7 +38,7 @@ SWUPD_FORMAT ??= "3"
 SWUPD_PINNED_PUBKEY ??= ""
 do_install_append () {
     # TODO: This should be a less os-specific directory and not hard-code datadir
-    install -d ${D}$/usr/share/clear/bundles
+    install -d ${D}/usr/share/clear/bundles
 
     # Write default values to the configuration hierarchy (since 3.4.0)
     install -d ${D}/usr/share/defaults/swupd
-- 
2.10.2

Re: [meta-swupd][PATCH] swupd-client: fix invalid directory in do_install_append()

[Patrick Ohly]

On Mon, 2016-11-28 at 12:18 +0000, André Draszik wrote:
> diff --git a/recipes-core/swupd-client/swupd-client_git.bb b/recipes-core/swupd-client/swupd-client_git.bb
> index fd4716f..3aed480 100644
> --- a/recipes-core/swupd-client/swupd-client_git.bb
> +++ b/recipes-core/swupd-client/swupd-client_git.bb
> @@ -38,7 +38,7 @@ SWUPD_FORMAT ??= "3"
>  SWUPD_PINNED_PUBKEY ??= ""
>  do_install_append () {
>      # TODO: This should be a less os-specific directory and not hard-code datadir
> -    install -d ${D}$/usr/share/clear/bundles
> +    install -d ${D}/usr/share/clear/bundles
>  
>      # Write default values to the configuration hierarchy (since 3.4.0)
>      install -d ${D}/usr/share/defaults/swupd

I'm about to remove this entire do_install_append.
create_bundle_manifest() in swupd-image.bbclass is what really creates
that directory, and onfiguring the image so that the swupd-client is
usable is part of image creation, not of compiling the client.

For example, different images may need different settings, and that
can't be done with settings compiled into swupd-client because it gets
built only once.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.