All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "flow_dissect: call init_default_flow_dissectors() earlier" has been added to the 4.8-stable tree
@ 2016-11-30 15:35 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-11-30 15:35 UTC (permalink / raw)
  To: edumazet, alexander.h.duyck, davem, gregkh, maan; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    flow_dissect: call init_default_flow_dissectors() earlier

to the 4.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     flow_dissect-call-init_default_flow_dissectors-earlier.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From c9b8af1330198ae241cd545e1f040019010d44d9 Mon Sep 17 00:00:00 2001
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 22 Nov 2016 11:17:30 -0800
Subject: flow_dissect: call init_default_flow_dissectors() earlier

From: Eric Dumazet <edumazet@google.com>

commit c9b8af1330198ae241cd545e1f040019010d44d9 upstream.

Andre Noll reported panics after my recent fix (commit 34fad54c2537
"net: __skb_flow_dissect() must cap its return value")

After some more headaches, Alexander root caused the problem to
init_default_flow_dissectors() being called too late, in case
a network driver like IGB is not a module and receives DHCP message
very early.

Fix is to call init_default_flow_dissectors() much earlier,
as it is a core infrastructure and does not depend on another
kernel service.

Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andre Noll <maan@tuebingen.mpg.de>
Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/core/flow_dissector.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -945,4 +945,4 @@ static int __init init_default_flow_diss
 	return 0;
 }
 
-late_initcall_sync(init_default_flow_dissectors);
+core_initcall(init_default_flow_dissectors);


Patches currently in stable-queue which might be from edumazet@google.com are

queue-4.8/flow_dissect-call-init_default_flow_dissectors-earlier.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-30 15:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 15:35 Patch "flow_dissect: call init_default_flow_dissectors() earlier" has been added to the 4.8-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.