Re: [PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

Re: [PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

[Thomas Gleixner]

On Thu, 1 Dec 2016, Piotr Luc wrote:

> The Knights Mill is enough close to Knights Landing so the path reuses
> C-state residency support of the latter.
>
> Signed-off-by: Piotr Luc <piotr.luc@intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: linux-kernel@vger.kernel.org

Please consult MAINTAINERS to figure out who should be on the CC list.

Thanks,

	tglx

[PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

[Piotr Luc]

The Knights Mill is enough close to Knights Landing so the path reuses
C-state residency support of the latter.

Signed-off-by: Piotr Luc <piotr.luc@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
index 4f5ac72..da51e5a 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);
-- 
2.10.1

Re: [PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

[Luc, Piotr]

On Thu, 2016-12-01 at 00:39 +0100, Thomas Gleixner wrote:
> On Thu, 1 Dec 2016, Piotr Luc wrote:
> 
> > 
> > The Knights Mill is enough close to Knights Landing so the path
> > reuses
> > C-state residency support of the latter.
> > 
> > Signed-off-by: Piotr Luc <piotr.luc@intel.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: x86@kernel.org
> > Cc: linux-kernel@vger.kernel.org
> 
> Please consult MAINTAINERS to figure out who should be on the CC
> list.
> 
> Thanks,
> 
> 	tglx

Thanks for picking this up.
I counted on get_maintainers.pl script, but it seems it used the
generic rule instead the specific one. I will correct CC list right
now.

Thanks
Piotr 

[RESEND PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

[Piotr Luc]

The Knights Mill is enough close to Knights Landing so the path reuses
C-state residency support of the latter.

Signed-off-by: Piotr Luc <piotr.luc@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
index 4f5ac72..da51e5a 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);
-- 
2.10.1

Fixed CC list.

+ Cc: Peter Zijlstra <peterz@infradead.org>
+ Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
+ Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
- Cc: Thomas Gleixner <tglx@linutronix.de>
- Cc: "H. Peter Anvin" <hpa@zytor.com>

[tip:perf/urgent] perf/x86/intel: Enable C-state residency events for Knights Mill

[tip-bot for Piotr Luc]

Commit-ID:  1dba23b12f49d7cf3d4504171c62541122b55141
Gitweb:     http://git.kernel.org/tip/1dba23b12f49d7cf3d4504171c62541122b55141
Author:     Piotr Luc <piotr.luc@intel.com>
AuthorDate: Thu, 1 Dec 2016 01:08:53 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 6 Dec 2016 09:44:27 +0100

perf/x86/intel: Enable C-state residency events for Knights Mill

The Knights Mill is enough close to Knights Landing so the path reuses
C-state residency support of the latter.

Signed-off-by: Piotr Luc <piotr.luc@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/20161201000853.18260-1-piotr.luc@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
index 4f5ac72..da51e5a 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);