From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] pwm: lpc32xx: remove handling of PWM channels
Date: Wed, 07 Dec 2016 12:58:16 -0500 [thread overview]
Message-ID: <1481133496.9248.3.camel@localhost> (raw)
In-Reply-To: <20161205014308.1741-2-vz@mleia.com>
On Mon, 2016-12-05 at 03:43 +0200, Vladimir Zapolskiy wrote:
> Because LPC32xx PWM controllers have single output which is registered as
> the only PWM device/channel per controller, it is known in advance that
> pwm->hwpwm value is always 0. On basis of this fact simplify the code
> by removing operations with pwm->hwpwm, there is no controls which require
> channel number as input.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> drivers/pwm/pwm-lpc32xx.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
Reviewed-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] pwm: lpc32xx: remove handling of PWM channels
Date: Wed, 07 Dec 2016 12:58:16 -0500 [thread overview]
Message-ID: <1481133496.9248.3.camel@localhost> (raw)
In-Reply-To: <20161205014308.1741-2-vz@mleia.com>
On Mon, 2016-12-05 at 03:43 +0200, Vladimir Zapolskiy wrote:
> Because LPC32xx PWM controllers have single output which is registered as
> the only PWM device/channel per controller, it is known in advance that
> pwm->hwpwm value is always 0. On basis of this fact simplify the code
> by removing operations with pwm->hwpwm, there is no controls which require
> channel number as input.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> drivers/pwm/pwm-lpc32xx.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
Reviewed-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
next prev parent reply other threads:[~2016-12-07 17:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 1:42 [PATCH 0/3] pwm: lpc32xx: switch driver to one phandle argument for PWM consumers Vladimir Zapolskiy
2016-12-05 1:42 ` Vladimir Zapolskiy
[not found] ` <20161205014237.1689-1-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2016-12-05 1:42 ` [PATCH 1/3] dt: pwm: lpc32xx: add description of clocks and #pwm-cells properties Vladimir Zapolskiy
2016-12-05 1:42 ` Vladimir Zapolskiy
[not found] ` <20161205014237.1689-2-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2016-12-07 17:56 ` Sylvain Lemieux
2016-12-07 17:56 ` Sylvain Lemieux
2016-12-09 21:41 ` Rob Herring
2016-12-09 21:41 ` Rob Herring
2016-12-09 23:51 ` Vladimir Zapolskiy
2016-12-09 23:51 ` Vladimir Zapolskiy
2016-12-21 3:30 ` Vladimir Zapolskiy
2016-12-21 3:30 ` Vladimir Zapolskiy
2017-01-03 15:22 ` Sylvain Lemieux
2017-01-03 15:22 ` Sylvain Lemieux
2017-02-07 19:03 ` Sylvain Lemieux
2017-02-07 19:03 ` Sylvain Lemieux
2017-02-07 23:22 ` Rob Herring
2017-02-07 23:22 ` Rob Herring
2016-12-05 1:43 ` [PATCH 2/3] pwm: lpc32xx: switch driver to one phandle argument for PWM consumers Vladimir Zapolskiy
2016-12-05 1:43 ` Vladimir Zapolskiy
2016-12-07 17:57 ` Sylvain Lemieux
2016-12-07 17:57 ` Sylvain Lemieux
2016-12-05 1:43 ` [PATCH 3/3] pwm: lpc32xx: remove handling of PWM channels Vladimir Zapolskiy
2016-12-05 1:43 ` Vladimir Zapolskiy
2016-12-07 17:58 ` Sylvain Lemieux [this message]
2016-12-07 17:58 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481133496.9248.3.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.