From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Input: lpc32xx-keys - fix invalid error handling of a requested irq
Date: Wed, 07 Dec 2016 13:51:32 -0500 [thread overview]
Message-ID: <1481136692.5635.1.camel@localhost> (raw)
In-Reply-To: <7AAD38C5-E1CF-40EF-8E5B-8BCB9B5897C4@gmail.com>
On Wed, 2016-12-07 at 10:46 -0800, Dmitry Torokhov wrote:
> On December 7, 2016 10:13:07 AM PST, Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> >On Mon, 2016-12-05 at 03:47 +0200, Vladimir Zapolskiy wrote:
> >> Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
> >> disabled or enabled, in the latter case IRQs are allocated starting
> >> at least from the value specified by NR_IRQS and going upwards, so
> >> the check of (irq >= NR_IRQ) to decide about an error code returned
> >by
> >> platform_get_irq() is completely invalid, don't attempt to overrule
> >> irq subsystem in the driver.
> >>
> >> The change fixes lpc32xx_keys driver initialization on boot:
> >>
> >> lpc32xx_keys 40050000.key: failed to get platform irq
> >> lpc32xx_keys: probe of 40050000.key failed with error -22
> >>
> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> >> ---
> >> drivers/input/keyboard/lpc32xx-keys.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >Cosmetic - please update the subject line when doing the commit:
> >replace " -" by ":" after lpc32xx-keys
>
> Why? The format on all input patches is "Input: <driver> - <subject>" and had been this for 10+ years.
>
My mistake; did not look at the tree "subject line" commit log
You can dropped my comment.
Regards,
Sylvain
>
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Input: lpc32xx-keys - fix invalid error handling of a requested irq
Date: Wed, 07 Dec 2016 13:51:32 -0500 [thread overview]
Message-ID: <1481136692.5635.1.camel@localhost> (raw)
In-Reply-To: <7AAD38C5-E1CF-40EF-8E5B-8BCB9B5897C4@gmail.com>
On Wed, 2016-12-07 at 10:46 -0800, Dmitry Torokhov wrote:
> On December 7, 2016 10:13:07 AM PST, Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> >On Mon, 2016-12-05 at 03:47 +0200, Vladimir Zapolskiy wrote:
> >> Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
> >> disabled or enabled, in the latter case IRQs are allocated starting
> >> at least from the value specified by NR_IRQS and going upwards, so
> >> the check of (irq >= NR_IRQ) to decide about an error code returned
> >by
> >> platform_get_irq() is completely invalid, don't attempt to overrule
> >> irq subsystem in the driver.
> >>
> >> The change fixes lpc32xx_keys driver initialization on boot:
> >>
> >> lpc32xx_keys 40050000.key: failed to get platform irq
> >> lpc32xx_keys: probe of 40050000.key failed with error -22
> >>
> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> >> ---
> >> drivers/input/keyboard/lpc32xx-keys.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >Cosmetic - please update the subject line when doing the commit:
> >replace " -" by ":" after lpc32xx-keys
>
> Why? The format on all input patches is "Input: <driver> - <subject>" and had been this for 10+ years.
>
My mistake; did not look at the tree "subject line" commit log
You can dropped my comment.
Regards,
Sylvain
>
> Thanks.
>
next prev parent reply other threads:[~2016-12-07 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 1:47 [PATCH] Input: lpc32xx-keys - fix invalid error handling of a requested irq Vladimir Zapolskiy
2016-12-05 1:47 ` Vladimir Zapolskiy
2016-12-07 18:13 ` Sylvain Lemieux
2016-12-07 18:13 ` Sylvain Lemieux
2016-12-07 18:46 ` Dmitry Torokhov
2016-12-07 18:46 ` Dmitry Torokhov
2016-12-07 18:51 ` Sylvain Lemieux [this message]
2016-12-07 18:51 ` Sylvain Lemieux
2016-12-08 1:22 ` Dmitry Torokhov
2016-12-08 1:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481136692.5635.1.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.