From: Joe Perches <joe@perches.com>
To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org,
daniel.lezcano@linaro.org, tglx@linutronix.de,
marc.zyngier@arm.com, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com,
hanjun.guo@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, rruigrok@codeaurora.org,
harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org,
graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com,
wei@redhat.com, arnd@arndb.de, catalin.marinas@arm.com,
will.deacon@arm.com, Suravee.Suthikulpanit@amd.com,
leo.duran@amd.com, wim@iguana.be, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, tn@semihalf.com,
christoffer.dall@linaro.org, julien.grall@arm.com
Subject: Re: [PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code
Date: Thu, 08 Dec 2016 13:10:30 -0800 [thread overview]
Message-ID: <1481231430.5946.34.camel@perches.com> (raw)
In-Reply-To: <20161208173319.6618-4-fu.wei@linaro.org>
On Fri, 2016-12-09 at 01:33 +0800, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patch defines pr_fmt(fmt) for all pr_* functions,
> then the pr_* doesn't need to add "arch_timer:" everytime.
trivia:
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
[]
> @@ -966,7 +967,7 @@ static int __init arch_timer_mem_init(struct device_node *np)
>
> ret = -EINVAL;
> if (!irq) {
> - pr_err("arch_timer: Frame missing %s irq",
> + pr_err("Frame missing %s irq",
> arch_timer_mem_use_virtual ? "virt" : "phys");
> goto out;
> }
Missing terminating newline
pr_err("Frame missing %s irq\n",
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code
Date: Thu, 08 Dec 2016 13:10:30 -0800 [thread overview]
Message-ID: <1481231430.5946.34.camel@perches.com> (raw)
In-Reply-To: <20161208173319.6618-4-fu.wei@linaro.org>
On Fri, 2016-12-09 at 01:33 +0800, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patch defines pr_fmt(fmt) for all pr_* functions,
> then the pr_* doesn't need to add "arch_timer:" everytime.
trivia:
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
[]
> @@ -966,7 +967,7 @@ static int __init arch_timer_mem_init(struct device_node *np)
>
> ret = -EINVAL;
> if (!irq) {
> - pr_err("arch_timer: Frame missing %s irq",
> + pr_err("Frame missing %s irq",
> arch_timer_mem_use_virtual ? "virt" : "phys");
> goto out;
> }
Missing terminating newline
pr_err("Frame missing %s irq\n",
next prev parent reply other threads:[~2016-12-08 21:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 17:33 [PATCH v18 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 01/15] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 02/15] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 21:10 ` Joe Perches [this message]
2016-12-08 21:10 ` Joe Perches
2016-12-09 8:24 ` Fu Wei
2016-12-09 8:24 ` Fu Wei
2016-12-09 8:24 ` Fu Wei
2016-12-08 17:33 ` [PATCH v18 04/15] clocksource/drivers/arm_arch_timer: rename some enums and defines fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 05/15] clocksource/drivers/arm_arch_timer: rework PPI determination fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 06/15] clocksource/drivers/arm_arch_timer: Rework counter frequency detection fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 07/15] clocksource/drivers/arm_arch_timer: Refactor arch_timer_needs_probing fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
[not found] ` <20161208173319.6618-1-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-12-08 17:33 ` [PATCH v18 08/15] clocksource/drivers/arm_arch_timer: move arch_timer_needs_of_probing into DT init call fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` fu.wei
2016-12-08 17:33 ` [PATCH v18 09/15] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code " fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 11/15] acpi/arm64: Add GTDT table parse driver fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 12/15] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 13/15] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` fu.wei
2016-12-08 17:33 ` [PATCH v18 14/15] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` [PATCH v18 15/15] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2016-12-08 17:33 ` fu.wei at linaro.org
2016-12-08 17:33 ` fu.wei
2017-01-13 19:29 ` [PATCH v18 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Mark Rutland
2017-01-13 19:29 ` Mark Rutland
2017-01-13 19:29 ` Mark Rutland
2017-01-14 11:34 ` Fu Wei
2017-01-14 11:34 ` Fu Wei
2017-01-14 11:34 ` Fu Wei
[not found] ` <CADyBb7vF0v2DwXA8fNUOTQcqriJK1Hp57_G8DKi0WO9FnvrB5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-16 0:54 ` Fu Wei
2017-01-16 0:54 ` Fu Wei
2017-01-16 0:54 ` Fu Wei
[not found] ` <CADyBb7ugz_YpxKQUsJbF1vdjm_Nzyh2mH8TZMPqj1cSHGSPCFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-16 11:59 ` Mark Rutland
2017-01-16 11:59 ` Mark Rutland
2017-01-16 11:59 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481231430.5946.34.camel@perches.com \
--to=joe@perches.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=julien.grall@arm.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=tn@semihalf.com \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.