drm/amdgpu/display: Multiple fixed-point implementations

drm/amdgpu/display: Multiple fixed-point implementations

[Hristo Venev]

[-- Attachment #1.1: Type: text/plain, Size: 668 bytes --]

There are at least three implementations of fixed-point arithmetic in
drm/amdgpu/display: fixed31_32 (signed 32-32), fixed32_32 (unsigned 32-
32) and bw_fixed (signed 40-24). I don't think fixed-point arithmetic
implementations belong in drivers.

There already are two implementations of fixed-point in drm: fixed20_12
(unsigned 20-12) and drm_fixp (signed 32-32). The latter could be used
instead of fixed31_32.

Maybe we could use a standard fixed-point interface and share the
source code between most (or all) of the implementations. This is one
of the things that can be done before merging DC and is not too driver-
specific. What do you guys think?

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: drm/amdgpu/display: Multiple fixed-point implementations

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Hristo Venev
> Sent: Saturday, December 10, 2016 5:29 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: drm/amdgpu/display: Multiple fixed-point implementations
> 
> There are at least three implementations of fixed-point arithmetic in
> drm/amdgpu/display: fixed31_32 (signed 32-32), fixed32_32 (unsigned 32-
> 32) and bw_fixed (signed 40-24). I don't think fixed-point arithmetic
> implementations belong in drivers.
> 
> There already are two implementations of fixed-point in drm: fixed20_12
> (unsigned 20-12) and drm_fixp (signed 32-32). The latter could be used
> instead of fixed31_32.
> 
> Maybe we could use a standard fixed-point interface and share the
> source code between most (or all) of the implementations. This is one
> of the things that can be done before merging DC and is not too driver-
> specific. What do you guys think?

Sure.  It would be nice to unify them especially if other drivers need them at some point.

Alex

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx