Re: [PATCH v2 3/5] i2c: designware-baytrail: Only check iosf_mbi_available() for shared hosts

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sat, 2016-12-10 at 15:19 +0100, Hans de Goede wrote:
> There is no need to delay the probe if iosf_mbi_available() returns
> false when an i2c bus is not using the punit semaphore.

> --- a/drivers/i2c/busses/i2c-designware-baytrail.c
> +++ b/drivers/i2c/busses/i2c-designware-baytrail.c
> @@ -139,14 +139,14 @@ int i2c_dw_eval_lock_support(struct dw_i2c_dev
> *dev)
>  		return 0;
>  
>  	if (shared_host) {
> +		if (!iosf_mbi_available())
> +			return -EPROBE_DEFER;
> +

Looking to the implementation of i2c_dw_eval_lock_support() I would
rewrite this like

if (!shared_host)
  return 0;

>  		dev_info(dev->dev, "I2C bus managed by PUNIT\n");
>  		dev->acquire_lock = baytrail_i2c_acquire;
>  		dev->release_lock = baytrail_i2c_release;
>  		dev->pm_runtime_disabled = true;
>  	}
>  
> -	if (!iosf_mbi_available())
> -		return -EPROBE_DEFER;
> -
>  	return 0;
>  }

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy