All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ben Evans <bevans@cray.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move
Date: Mon, 12 Dec 2016 11:52:00 -0800	[thread overview]
Message-ID: <1481572320.1764.35.camel@perches.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1612121936370.29051@casper.infradead.org>

On Mon, 2016-12-12 at 19:41 +0000, James Simmons wrote:
> > On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote:
[]
> > http://wiki.lustre.org/Lustre_Style_Guide_Includes
> > 
> > There is no single mandated code style for this.
> > Some people like reverse christmas tree.
> > 
> > Whatever...
> > 
> Sigh, Sayre's law.

<chuckle>

> I went looking to see what the offical
> policy is for this and found nothing. If this is really 
> important can we then place an offical policy on how
> headers are added to a C file in CodingStyle and add
> something to checkpatch to detect incorrect patches.
> Lets burn down this bike shed once and for all. 

g'luck with that.

David Miller might like to have a word with you too.

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ben Evans <bevans@cray.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move
Date: Mon, 12 Dec 2016 11:52:00 -0800	[thread overview]
Message-ID: <1481572320.1764.35.camel@perches.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1612121936370.29051@casper.infradead.org>

On Mon, 2016-12-12 at 19:41 +0000, James Simmons wrote:
> > On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote:
[]
> > http://wiki.lustre.org/Lustre_Style_Guide_Includes
> > 
> > There is no single mandated code style for this.
> > Some people like reverse christmas tree.
> > 
> > Whatever...
> > 
> Sigh, Sayre's law.

<chuckle>

> I went looking to see what the offical
> policy is for this and found nothing. If this is really 
> important can we then place an offical policy on how
> headers are added to a C file in CodingStyle and add
> something to checkpatch to detect incorrect patches.
> Lets burn down this bike shed once and for all. 

g'luck with that.

David Miller might like to have a word with you too.

  reply	other threads:[~2016-12-12 19:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10 18:05 [lustre-devel] [PATCH v2 0/5] Fix ups to make lustre_idl.h a proper UAPI header James Simmons
2016-12-10 18:05 ` James Simmons
2016-12-10 18:05 ` [lustre-devel] [PATCH v2 1/5] staging: lustre: obdclass: Create a header for obdo related functions James Simmons
2016-12-10 18:05   ` James Simmons
2016-12-10 18:05 ` [lustre-devel] [PATCH v2 2/5] staging: lustre: obdclass: style cleanup " James Simmons
2016-12-10 18:05   ` James Simmons
2016-12-10 18:05 ` [lustre-devel] [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move James Simmons
2016-12-10 18:05   ` James Simmons
2016-12-10 18:14   ` [lustre-devel] " Greg Kroah-Hartman
2016-12-10 18:14     ` Greg Kroah-Hartman
2016-12-12 14:42     ` [lustre-devel] " Ben Evans
2016-12-12 14:42       ` Ben Evans
2016-12-12 16:34       ` [lustre-devel] " Greg Kroah-Hartman
2016-12-12 16:34         ` Greg Kroah-Hartman
2016-12-12 18:12         ` [lustre-devel] " Ben Evans
2016-12-12 18:12           ` Ben Evans
2016-12-12 18:19         ` [lustre-devel] " Joe Perches
2016-12-12 18:19           ` Joe Perches
2016-12-12 19:41           ` [lustre-devel] " James Simmons
2016-12-12 19:41             ` James Simmons
2016-12-12 19:52             ` Joe Perches [this message]
2016-12-12 19:52               ` Joe Perches
2016-12-10 18:06 ` [lustre-devel] [PATCH v2 4/5] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons
2016-12-10 18:06   ` James Simmons
2016-12-10 18:06 ` [lustre-devel] [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons
2016-12-10 18:06   ` James Simmons
2016-12-10 18:16   ` [lustre-devel] " Greg Kroah-Hartman
2016-12-10 18:16     ` Greg Kroah-Hartman
2016-12-12 20:00     ` [lustre-devel] " James Simmons
2016-12-12 20:00       ` James Simmons
2016-12-13  0:37       ` [lustre-devel] " Greg Kroah-Hartman
2016-12-13  0:37         ` Greg Kroah-Hartman
2016-12-13  8:31         ` [lustre-devel] " Dan Carpenter
2016-12-13  8:31           ` Dan Carpenter
2016-12-13 16:14           ` [lustre-devel] " Oleg Drokin
2016-12-13 16:14             ` Oleg Drokin
2016-12-13 17:21             ` [lustre-devel] " Dan Carpenter
2016-12-13 17:21               ` Dan Carpenter
2016-12-13  0:55       ` [lustre-devel] " Dilger, Andreas
2016-12-13  0:55         ` Dilger, Andreas
2016-12-13  1:07         ` [lustre-devel] " Greg Kroah-Hartman
2016-12-13  1:07           ` Greg Kroah-Hartman
2016-12-19 17:02           ` [lustre-devel] " James Simmons
2016-12-19 17:02             ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481572320.1764.35.camel@perches.com \
    --to=joe@perches.com \
    --cc=andreas.dilger@intel.com \
    --cc=bevans@cray.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.