From: Gerd Hoffmann <kraxel@redhat.com>
To: Pierre Ossman <ossman@cendio.se>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] VNC LED state buggy, interop issue
Date: Tue, 13 Dec 2016 09:06:02 +0100 [thread overview]
Message-ID: <1481616362.27088.74.camel@redhat.com> (raw)
In-Reply-To: <f460049b-211e-194b-d4c3-a3cc34e4d289@cendio.se>
Hi,
> The basic problem is that the code right now assumes that XK_Caps_Lock
> and XK_Num_Lock will toggle their respective states. It is however not
> assumed that XK_Scroll_Lock toggles any state.
The whole thing is more intended to make sure guest and host have the
same idea about numlock and capslock state, so input works propery, not
so much about making the leds blink properly.
And, yes, it assumes you don't remap capslock + numlock keys to
something else (in the guest). vnc has an option (lock-key-sync) to
turn off this logic in case it causes problems because the assumtion
doesn't hold for a specific guest.
> b) Remove the assumption from the code and the protocol.
Patches are welcome.
cheers,
Gerd
next prev parent reply other threads:[~2016-12-13 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 15:30 [Qemu-devel] VNC LED state buggy, interop issue Pierre Ossman
2016-12-12 9:11 ` Pierre Ossman
2016-12-13 8:06 ` Gerd Hoffmann [this message]
2016-12-13 13:10 ` Pierre Ossman
2016-12-13 13:15 ` Daniel P. Berrange
2016-12-13 13:37 ` Pierre Ossman
2016-12-13 14:44 ` Pierre Ossman
2016-12-14 7:31 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2016-12-10 15:07 Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481616362.27088.74.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ossman@cendio.se \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.