All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Pierre Ossman <ossman@cendio.se>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] VNC LED state buggy, interop issue
Date: Tue, 13 Dec 2016 13:15:53 +0000	[thread overview]
Message-ID: <20161213131553.GJ28416@redhat.com> (raw)
In-Reply-To: <7ba29954-e3ad-529c-9978-b10d2788f9e4@cendio.se>

On Tue, Dec 13, 2016 at 02:10:04PM +0100, Pierre Ossman wrote:
> On 13/12/16 09:06, Gerd Hoffmann wrote:
> > >   b) Remove the assumption from the code and the protocol.
> > 
> > Patches are welcome.
> > 
> 
> I was just aiming for a consensus on the intended behaviour, rather than fix
> the bug right now. :)
> But all right, attached patch is an attempt.
> 
> Btw, is there any client that implements this extension yet? I couldn't find
> anything.

gtk-vnc implements the LED state extension.

IIRC, there have been bug reports about it being mostly useless with
QEMU, since it only reflects LED changes initiated by the guest,
and not those initiated by virtual key presses sent by GTK-VNC.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

  reply	other threads:[~2016-12-13 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10 15:30 [Qemu-devel] VNC LED state buggy, interop issue Pierre Ossman
2016-12-12  9:11 ` Pierre Ossman
2016-12-13  8:06 ` Gerd Hoffmann
2016-12-13 13:10   ` Pierre Ossman
2016-12-13 13:15     ` Daniel P. Berrange [this message]
2016-12-13 13:37       ` Pierre Ossman
2016-12-13 14:44       ` Pierre Ossman
2016-12-14  7:31     ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2016-12-10 15:07 Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213131553.GJ28416@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=ossman@cendio.se \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.