* [PATCH linux 6/7] arm: aspeed: dts: Add I2C POWER8 OCC compatible string
@ 2016-12-16 20:36 eajames.ibm
2016-12-20 0:55 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: eajames.ibm @ 2016-12-16 20:36 UTC (permalink / raw)
To: openbmc; +Cc: andrew, joel, Edward A. James
From: "Edward A. James" <eajames@us.ibm.com>
Add devicetree entry to probe up the POWER8 OCC driver on I2C bus.
Signed-off-by: Edward A. James <eajames@us.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
index cc5fcf2..1a775f5 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
@@ -20,6 +20,15 @@
};
};
+&i2c3 {
+ status = "okay";
+
+ occ@50 {
+ compatible = "ibm,p8-occ-i2c";
+ reg = <0x50>;
+ };
+};
+
&uart5 {
status = "okay";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH linux 6/7] arm: aspeed: dts: Add I2C POWER8 OCC compatible string
2016-12-16 20:36 [PATCH linux 6/7] arm: aspeed: dts: Add I2C POWER8 OCC compatible string eajames.ibm
@ 2016-12-20 0:55 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2016-12-20 0:55 UTC (permalink / raw)
To: eajames.ibm, openbmc; +Cc: joel, Edward A. James
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On Fri, 2016-12-16 at 14:36 -0600, eajames.ibm@gmail.com wrote:
> > From: "Edward A. James" <eajames@us.ibm.com>
>
> Add devicetree entry to probe up the POWER8 OCC driver on I2C bus.
>
> > Signed-off-by: Edward A. James <eajames@us.ibm.com>
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index cc5fcf2..1a775f5 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -20,6 +20,15 @@
> > };
> };
>
> +&i2c3 {
> > + status = "okay";
> +
> > + occ@50 {
> > + compatible = "ibm,p8-occ-i2c";
> > + reg = <0x50>;
> > + };
> +};
> +
> &uart5 {
> > status = "okay";
> };
This patch should be split out into a separate series that gets sent to
the Aspeed maintainer (Joel).
However, it looks good. Given it's been completely re-written I'd drop
my signed-off-by. Instead you can add:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Andrew
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-20 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-16 20:36 [PATCH linux 6/7] arm: aspeed: dts: Add I2C POWER8 OCC compatible string eajames.ibm
2016-12-20 0:55 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.