From: Joe Perches <joe@perches.com>
To: Aditya Srivastava <yashsri421@gmail.com>, lukas.bulwahn@gmail.com
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v4] checkpatch: add fix and improve warning msg for Non-standard signature
Date: Mon, 23 Nov 2020 09:33:29 -0800 [thread overview]
Message-ID: <148208ef84344069a6c95d3f686a86ca1199be90.camel@perches.com> (raw)
In-Reply-To: <20201123172430.12854-1-yashsri421@gmail.com>
On Mon, 2020-11-23 at 22:54 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
> styles.
I think this proposed change is unnecessary.
> This warning occurs because of incorrect use of signature tags,
> e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect
> signature tags, which may seem correct, but are not standard:
Standards are useful, but standards are not constraints.
> 1) Requested-by (count: 48) => Suggested-by
> Rationale: In an open-source project, there are no 'requests', just
> 'suggestions' to convince a maintainer to accept your patch
There's nothing really wrong with some non-standard signatures.
And I think leaving humor like brown-paper-bag-by: is useful.
Just telling people that they are using a non-standard signature
I think is enough.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Aditya Srivastava <yashsri421@gmail.com>, lukas.bulwahn@gmail.com
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] checkpatch: add fix and improve warning msg for Non-standard signature
Date: Mon, 23 Nov 2020 09:33:29 -0800 [thread overview]
Message-ID: <148208ef84344069a6c95d3f686a86ca1199be90.camel@perches.com> (raw)
In-Reply-To: <20201123172430.12854-1-yashsri421@gmail.com>
On Mon, 2020-11-23 at 22:54 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
> styles.
I think this proposed change is unnecessary.
> This warning occurs because of incorrect use of signature tags,
> e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect
> signature tags, which may seem correct, but are not standard:
Standards are useful, but standards are not constraints.
> 1) Requested-by (count: 48) => Suggested-by
> Rationale: In an open-source project, there are no 'requests', just
> 'suggestions' to convince a maintainer to accept your patch
There's nothing really wrong with some non-standard signatures.
And I think leaving humor like brown-paper-bag-by: is useful.
Just telling people that they are using a non-standard signature
I think is enough.
next prev parent reply other threads:[~2020-11-23 17:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:04 [Linux-kernel-mentees] [PATCH v3] checkpatch: add fix and improve warning msg for Non-standard signature Aditya Srivastava
2020-11-23 15:04 ` Aditya Srivastava
2020-11-23 15:16 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-11-23 15:16 ` Lukas Bulwahn
2020-11-23 17:24 ` [Linux-kernel-mentees] [PATCH v4] " Aditya Srivastava
2020-11-23 17:24 ` Aditya Srivastava
2020-11-23 17:33 ` Joe Perches [this message]
2020-11-23 17:33 ` Joe Perches
2020-11-24 3:12 ` [Linux-kernel-mentees] " Aditya
2020-11-24 3:12 ` Aditya
2020-11-24 6:54 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-11-24 6:54 ` Lukas Bulwahn
2020-11-24 7:26 ` [Linux-kernel-mentees] " Joe Perches
2020-11-24 7:26 ` Joe Perches
2020-11-24 7:44 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-11-24 7:44 ` Lukas Bulwahn
-- strict thread matches above, loose matches on Subject: below --
2020-11-25 12:26 [Linux-kernel-mentees] [PATCH v3] " Lukas Bulwahn
2020-11-28 9:52 ` [Linux-kernel-mentees] [PATCH v4] checkpatch: add fix and improve warning msg for non-standard signature Aditya Srivastava
2020-11-28 13:00 ` Lukas Bulwahn
2020-11-28 13:05 Aditya Srivastava
2020-11-28 15:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148208ef84344069a6c95d3f686a86ca1199be90.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.