All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
	Eric Biggers <ebiggers3@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Kirill Marinushkin <k.marinushkin@gmail.com>,
	security@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] security/keys: rewrite all of big_key crypto
Date: Tue, 06 Jun 2017 17:58:16 +0000	[thread overview]
Message-ID: <14825.1496771896@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170606173900.29279-1-Jason@zx2c4.com>

Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> This commit has been compile-tested only, so I'd appreciate it if
> somebody else who actually uses this would test it for functionality, or
> if somebody into the kernel's crypto API would check that it's been done
> correctly.

You need to test it.  You can do this with:

	dd ... | keyctl padd big_key fred @s

This will print a key ID.  Then you can retrieve the contents with:

	keyctl pipe <key-id> | ...

David

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
	Eric Biggers <ebiggers3@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Kirill Marinushkin <k.marinushkin@gmail.com>,
	security@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] security/keys: rewrite all of big_key crypto
Date: Tue, 06 Jun 2017 18:58:16 +0100	[thread overview]
Message-ID: <14825.1496771896@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170606173900.29279-1-Jason@zx2c4.com>

Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> This commit has been compile-tested only, so I'd appreciate it if
> somebody else who actually uses this would test it for functionality, or
> if somebody into the kernel's crypto API would check that it's been done
> correctly.

You need to test it.  You can do this with:

	dd ... | keyctl padd big_key fred @s

This will print a key ID.  Then you can retrieve the contents with:

	keyctl pipe <key-id> | ...

David

  parent reply	other threads:[~2017-06-06 17:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 17:39 [PATCH] security/keys: rewrite all of big_key crypto Jason A. Donenfeld
2017-06-06 17:39 ` Jason A. Donenfeld
2017-06-06 17:40 ` Jason A. Donenfeld
2017-06-06 17:40   ` Jason A. Donenfeld
2017-06-06 17:49 ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 17:49   ` Jason A. Donenfeld
2017-06-06 17:49   ` Jason A. Donenfeld
2017-06-06 17:58 ` David Howells [this message]
2017-06-06 17:58   ` David Howells
2017-06-06 18:25   ` Jason A. Donenfeld
2017-06-06 18:25     ` Jason A. Donenfeld
2017-06-06 18:45     ` David Howells
2017-06-06 18:45       ` David Howells
2017-06-06 19:18       ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 19:18         ` Jason A. Donenfeld
2017-06-06 19:18         ` Jason A. Donenfeld
2017-06-06 20:58 ` Eric Biggers
2017-06-06 20:58   ` Eric Biggers
2017-06-06 21:31   ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 21:31     ` Jason A. Donenfeld
2017-06-06 21:31     ` Jason A. Donenfeld
2017-06-07  5:14 ` Stephan Müller
2017-06-07  5:14   ` Stephan Müller
2017-06-07 10:09   ` Jason A. Donenfeld
2017-06-07 10:09     ` Jason A. Donenfeld
2017-06-07 11:30     ` Stephan Müller
2017-06-07 11:30       ` Stephan Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14825.1496771896@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Jason@zx2c4.com \
    --cc=ebiggers3@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=k.marinushkin@gmail.com \
    --cc=keyrings@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.