All of lore.kernel.org
 help / color / mirror / Atom feed
* [Openvpn-devel] [PATCH] Document that RSA_SIGN can also request TLS 1.2 signatures
@ 2016-12-25 22:38 Steffan Karger
  2016-12-26  9:36 ` Arne Schwabe
  2016-12-26 12:19 ` [Openvpn-devel] [PATCH applied] " David Sommerseth
  0 siblings, 2 replies; 3+ messages in thread
From: Steffan Karger @ 2016-12-25 22:38 UTC (permalink / raw)
  To: openvpn-devel

Ever since we support TLS 1.2 (OpenVPN 2.3.3+), the RSA_SIGN might not
only request MD5-SHA1 'TLS signatures', but also other variants.
Document this by updating the implementation hints, and explicitly
stating that we expect a PKCS#1 1.5 signature.

Trac: #764

Signed-off-by: Steffan Karger <steffan@...1856...>
---
 doc/management-notes.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/management-notes.txt b/doc/management-notes.txt
index dd870eb..29c3aad 100644
--- a/doc/management-notes.txt
+++ b/doc/management-notes.txt
@@ -773,8 +773,9 @@ via a notification as follows:
 
 >RSA_SIGN:[BASE64_DATA]
 
-The management interface client should then sign BASE64_DATA
-using the private key and return the SSL signature as follows:
+The management interface client should then create a PKCS#1 v1.5 signature of
+the (decoded) BASE64_DATA using the private key and return the SSL signature as
+follows:
 
 rsa-sig
 [BASE64_SIG_LINE]
@@ -783,8 +784,8 @@ rsa-sig
 .
 END
 
-Base64 encoded output of RSA_sign(NID_md5_sha1,... will provide a
-correct signature.
+Base64 encoded output of RSA_private_encrypt() (OpenSSL) or mbedtls_pk_sign()
+(mbed TLS) will provide a correct signature.
 
 This capability is intended to allow the use of arbitrary cryptographic
 service providers with OpenVPN via the management interface.
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Openvpn-devel] [PATCH] Document that RSA_SIGN can also request TLS 1.2 signatures
  2016-12-25 22:38 [Openvpn-devel] [PATCH] Document that RSA_SIGN can also request TLS 1.2 signatures Steffan Karger
@ 2016-12-26  9:36 ` Arne Schwabe
  2016-12-26 12:19 ` [Openvpn-devel] [PATCH applied] " David Sommerseth
  1 sibling, 0 replies; 3+ messages in thread
From: Arne Schwabe @ 2016-12-26  9:36 UTC (permalink / raw)
  To: Steffan Karger <steffan@

Am 25.12.16 um 22:38 schrieb Steffan Karger:
> Ever since we support TLS 1.2 (OpenVPN 2.3.3+), the RSA_SIGN might not
> only request MD5-SHA1 'TLS signatures', but also other variants.
> Document this by updating the implementation hints, and explicitly
> stating that we expect a PKCS#1 1.5 signature.

ACK. I ran into this. ;)

Arne


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Openvpn-devel] [PATCH applied] Document that RSA_SIGN can also request TLS 1.2 signatures
  2016-12-25 22:38 [Openvpn-devel] [PATCH] Document that RSA_SIGN can also request TLS 1.2 signatures Steffan Karger
  2016-12-26  9:36 ` Arne Schwabe
@ 2016-12-26 12:19 ` David Sommerseth
  1 sibling, 0 replies; 3+ messages in thread
From: David Sommerseth @ 2016-12-26 12:19 UTC (permalink / raw)
  To: steffan@; +Cc: openvpn-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Your patch has been applied to the following branches

commit 1e36b814073c0f56c77e4922cc105f00b8558e7e  (master)
commit 9b42853eea285ad54aed8b466e7f5a789a943933  (release/2.4)
Author: Steffan Karger
Date:   Sun Dec 25 23:38:25 2016 +0100

     Document that RSA_SIGN can also request TLS 1.2 signatures

     Trac: #764
     Signed-off-by: Steffan Karger <steffan@...1856...>
     Acked-by: Arne Schwabe <arne@...1227...>
     Message-Id: <1482705505-20302-1-git-send-email-steffan@...1856...>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13714.html
     Signed-off-by: David Sommerseth <davids@...515...>


- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJYYQq6AAoJEIbPlEyWcf3ydS8P/iZDyUGQdlOu+05vZlKY8xTo
jK4SkBXud7aleJvTUncQ3YCWBccNfYOlD2iVNKQSmwxsFB5aGunvvpujT99e9ZQk
TpWXImERqtbmkd/dMmhBiAGZizNuXhFwX9SgFYI/OCnfQRj9vMaDBbdLo+AM9d8q
s2iNTLlEiZYb3+RBV6z6uNgIb8JDOPKDlmbqMZma7TqlpfsbTEQWJe+SpIniglxa
/7/ubglukfQQJjxFtQ0/uSapjN64fyXxsDQsQTUZPALTViDC+G/R3KW4VClZVcpa
Jsy+ceIlkhUQIC0QVhx7B2mkdyTa4rIN/3a3ytU2WByl4rmDq9FwT406HFjm6D4r
0I5p96iuWK6aYXYW5QB6QfPOh2EtmFZuW7WE/N0BJyXxo+pDyKaGGwTOWiFSEWd7
HrXlTFSkxBk50XYavTmYC7jWLKhcus7GHMjnthSnj8E4DLcsblFiwCluT6aH94yf
q0WocsLfBoJUpUUyaY4pLZcb9aRBIZQK/i9o439cu2UfKnAw6Og0Gwsin71z170y
V0ahR3SmmF03+KgA1TQv9VvEuPbsORZb9QaZhalkTKgIAKNBzrkV8XdWlIYZngIi
hZJug7KVQxo6UHW1NWlhlSVpMt6XGf8YSclDzgu3mGyrO5s6zUivCyK8V1LG6EMb
panYszBADhJrItOgjRTS
=w1zq
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-26 12:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-25 22:38 [Openvpn-devel] [PATCH] Document that RSA_SIGN can also request TLS 1.2 signatures Steffan Karger
2016-12-26  9:36 ` Arne Schwabe
2016-12-26 12:19 ` [Openvpn-devel] [PATCH applied] " David Sommerseth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.