From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] checkpatch: don't warn on every struct without const_structs file
Date: Tue, 10 Jan 2017 07:01:57 -0800 [thread overview]
Message-ID: <1484060517.2106.38.camel@perches.com> (raw)
In-Reply-To: <20170110140318.737-1-johannes@sipsolutions.net>
On Tue, 2017-01-10 at 15:03 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The script says that it won't warn:
> "No structs that should be const will be found [...]"
>
> but then that doesn't work and it warns on every single struct
> instead, since the regular expression ends up empty. Fix that
> by checking that it's not empty first.
nak.
How does const_structs end up empty for you?
next prev parent reply other threads:[~2017-01-10 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:03 [PATCH] checkpatch: don't warn on every struct without const_structs file Johannes Berg
2017-01-10 15:01 ` Joe Perches [this message]
2017-01-10 15:04 ` Johannes Berg
2017-01-10 16:27 ` Joe Perches
2017-01-10 16:31 ` Johannes Berg
2017-01-10 16:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484060517.2106.38.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.