From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: don't warn on every struct without const_structs file
Date: Tue, 10 Jan 2017 17:31:26 +0100 [thread overview]
Message-ID: <1484065886.1014.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1484065662.12006.2.camel@perches.com>
> > I copied checkpatch elsewhere and ran it.
>
> Why do you want to copy checkpatch "someplace else"?
> Instead of copy, I think you should soft link it.
Well, no, I have to distribute it with that.
> > Regardless, the current code is utterly stupid - it prints a
> > warning that it won't flag any structs, and then proceeds to flag
> > all structs.
> >
> > If you must, send a patch to abort() [whatever the perl equivalent
> > is] when the file can't be found, but as it is, the code is just
> > idiotic.
>
> Maybe so.
>
> As is, your patch description is incomplete because
> it doesn't mention your use case.
I don't think that's relevant. The script is internally inconsistent,
as I do mention in the commit log, which is worth fixing.
johannes
next prev parent reply other threads:[~2017-01-10 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:03 [PATCH] checkpatch: don't warn on every struct without const_structs file Johannes Berg
2017-01-10 15:01 ` Joe Perches
2017-01-10 15:04 ` Johannes Berg
2017-01-10 16:27 ` Joe Perches
2017-01-10 16:31 ` Johannes Berg [this message]
2017-01-10 16:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484065886.1014.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.