From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union
Date: Fri, 13 Jan 2017 13:26:02 +0200 [thread overview]
Message-ID: <1484306762.3373.20.camel@linux.intel.com> (raw)
In-Reply-To: <20170113103311.7679-6-chris@chris-wilson.co.uk>
On pe, 2017-01-13 at 10:33 +0000, Chris Wilson wrote:
> Reading the ggtt_views is much more pleasant without the extra
> characters from specifying the union (i.e. ggtt_view.partial rather than
> ggtt_view.params.partial). To make this work inside i915_vma_compare()
> with only a single memcmp requires us to ensure that there are no
> uninitialised bytes within each branch of the union (we make sure the
> structs are packed) and we need to store the size of each branch.
>
> v4: Rewrite changelog and add comments explaining the assert.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-13 11:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 10:33 Anonymoose ggtt_view_params Chris Wilson
2017-01-13 10:33 ` [PATCH v3 1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view Chris Wilson
2017-01-13 10:33 ` [PATCH v3 2/7] drm/i915: Mark the ggtt_view structs as packed Chris Wilson
2017-01-13 10:33 ` [PATCH v3 3/7] drm/i915: Compact memcmp in i915_vma_compare() Chris Wilson
2017-01-13 10:33 ` [PATCH v3 4/7] drm/i915: Stop clearing i915_ggtt_view Chris Wilson
2017-01-13 10:33 ` [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union Chris Wilson
2017-01-13 11:12 ` Tvrtko Ursulin
2017-01-13 11:26 ` Joonas Lahtinen [this message]
2017-01-13 10:33 ` [PATCH v3 6/7] drm/i915: Eliminate superfluous i915_ggtt_view_rotated Chris Wilson
2017-01-13 10:33 ` [PATCH v3 7/7] drm/i915: Eliminate superfluous i915_ggtt_view_normal Chris Wilson
2017-01-13 10:59 ` Anonymoose ggtt_view_params Tvrtko Ursulin
2017-01-13 11:11 ` Chris Wilson
2017-01-13 11:23 ` Tvrtko Ursulin
2017-01-13 11:34 ` Chris Wilson
2017-01-13 11:23 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484306762.3373.20.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.