From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: Anonymoose ggtt_view_params
Date: Fri, 13 Jan 2017 10:59:46 +0000 [thread overview]
Message-ID: <2530866f-9663-5901-e500-10019f246f4b@linux.intel.com> (raw)
In-Reply-To: <20170113103311.7679-1-chris@chris-wilson.co.uk>
On 13/01/2017 10:33, Chris Wilson wrote:
> Ok, ok, this cover note only exists to continue the run on joke of my
> mispellings!
>
> Everything but
> [5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union
> has a r-b, so this is a good time to complain if this is too much of a
> hack.
If you could polish your clouded crystal ball to see if more view types
might be coming, which then might have a colliding parameters size and
foil the whole idea.
I do think it is a little bit of hack with a questionable benefit. And I
think I asked a few times if you really see a performance difference for
a few bytes smaller memcmp? Presumably it would be some test case with a
huge number of partial views which could theoretically maybe show something?
Downside is if we need to revert it would be relatively "churny".
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-13 10:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 10:33 Anonymoose ggtt_view_params Chris Wilson
2017-01-13 10:33 ` [PATCH v3 1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view Chris Wilson
2017-01-13 10:33 ` [PATCH v3 2/7] drm/i915: Mark the ggtt_view structs as packed Chris Wilson
2017-01-13 10:33 ` [PATCH v3 3/7] drm/i915: Compact memcmp in i915_vma_compare() Chris Wilson
2017-01-13 10:33 ` [PATCH v3 4/7] drm/i915: Stop clearing i915_ggtt_view Chris Wilson
2017-01-13 10:33 ` [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union Chris Wilson
2017-01-13 11:12 ` Tvrtko Ursulin
2017-01-13 11:26 ` Joonas Lahtinen
2017-01-13 10:33 ` [PATCH v3 6/7] drm/i915: Eliminate superfluous i915_ggtt_view_rotated Chris Wilson
2017-01-13 10:33 ` [PATCH v3 7/7] drm/i915: Eliminate superfluous i915_ggtt_view_normal Chris Wilson
2017-01-13 10:59 ` Tvrtko Ursulin [this message]
2017-01-13 11:11 ` Anonymoose ggtt_view_params Chris Wilson
2017-01-13 11:23 ` Tvrtko Ursulin
2017-01-13 11:34 ` Chris Wilson
2017-01-13 11:23 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/7] drm/i915: Name the anonymous structs inside i915_ggtt_view Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2530866f-9663-5901-e500-10019f246f4b@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.