All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	David Safford <safford@us.ibm.com>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KEYS: Fix an error code in request_master_key()
Date: Mon, 16 Jan 2017 13:58:50 +0000	[thread overview]
Message-ID: <1484575130.5538.2.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <11899.1484226513@warthog.procyon.org.uk>

On Thu, 2017-01-12 at 13:08 +0000, David Howells wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> 
> > On Fri, 2016-12-16 at 12:08 +0300, Dan Carpenter wrote:
> > > This function has two callers and neither are able to handle a NULL
> > > return.  Really, -EINVAL is the correct thing return here anyway.  This
> > > fixes some static checker warnings like:
> > > 
> > > 	security/keys/encrypted-keys/encrypted.c:709 encrypted_key_decrypt()
> > > 	error: uninitialized symbol 'master_key'.
> > > 
> > > Fixes: 7e70cb497850 ("keys: add new key-type encrypted")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > Thanks!
> 
> Can I put that down as an Acked-by or Reviewed-by?

Feel free to add by "Acked-by" on both this patch and Dan's other patch
"KEYS: Use memzero_explicit() for secret data".

Mimi



WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	David Safford <safford@us.ibm.com>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KEYS: Fix an error code in request_master_key()
Date: Mon, 16 Jan 2017 08:58:50 -0500	[thread overview]
Message-ID: <1484575130.5538.2.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <11899.1484226513@warthog.procyon.org.uk>

On Thu, 2017-01-12 at 13:08 +0000, David Howells wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> 
> > On Fri, 2016-12-16 at 12:08 +0300, Dan Carpenter wrote:
> > > This function has two callers and neither are able to handle a NULL
> > > return.  Really, -EINVAL is the correct thing return here anyway.  This
> > > fixes some static checker warnings like:
> > > 
> > > 	security/keys/encrypted-keys/encrypted.c:709 encrypted_key_decrypt()
> > > 	error: uninitialized symbol 'master_key'.
> > > 
> > > Fixes: 7e70cb497850 ("keys: add new key-type encrypted")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > Thanks!
> 
> Can I put that down as an Acked-by or Reviewed-by?

Feel free to add by "Acked-by" on both this patch and Dan's other patch
"KEYS: Use memzero_explicit() for secret data".

Mimi

  reply	other threads:[~2017-01-16 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  9:08 [patch] KEYS: Fix an error code in request_master_key() Dan Carpenter
2016-12-16  9:08 ` Dan Carpenter
2016-12-16 16:50 ` Mimi Zohar
2016-12-16 16:50   ` Mimi Zohar
2017-01-12 13:08   ` David Howells
2017-01-16 13:58     ` Mimi Zohar [this message]
2017-01-16 13:58       ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484575130.5538.2.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=safford@us.ibm.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.