* [PATCH] drm: Show leaked connectors upon unload
@ 2017-01-19 9:05 Chris Wilson
2017-01-19 11:24 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Chris Wilson @ 2017-01-19 9:05 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
After warning that the connector list is not empty on device
unregistration (i.e. module unload) also print out which connectors are
still hanging around to aide finding the leak.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/drm_mode_config.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index ed1ee5a44a7b..884cc4d26fb5 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -421,7 +421,12 @@ void drm_mode_config_cleanup(struct drm_device *dev)
drm_connector_unreference(connector);
}
drm_connector_list_iter_put(&conn_iter);
- WARN_ON(!list_empty(&dev->mode_config.connector_list));
+ if (WARN_ON(!list_empty(&dev->mode_config.connector_list))) {
+ drm_connector_list_iter_get(dev, &conn_iter);
+ drm_for_each_connector_iter(connector, &conn_iter)
+ DRM_ERROR("connector %s leaked!\n", connector->name);
+ drm_connector_list_iter_put(&conn_iter);
+ }
list_for_each_entry_safe(property, pt, &dev->mode_config.property_list,
head) {
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for drm: Show leaked connectors upon unload 2017-01-19 9:05 [PATCH] drm: Show leaked connectors upon unload Chris Wilson @ 2017-01-19 11:24 ` Patchwork 2017-01-19 11:32 ` Chris Wilson 2017-01-19 13:36 ` [PATCH] " Joonas Lahtinen 2017-01-19 14:17 ` Maarten Lankhorst 2 siblings, 1 reply; 8+ messages in thread From: Patchwork @ 2017-01-19 11:24 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm: Show leaked connectors upon unload URL : https://patchwork.freedesktop.org/series/18219/ State : success == Summary == Series 18219v1 drm: Show leaked connectors upon unload https://patchwork.freedesktop.org/api/1.0/series/18219/revisions/1/mbox/ Test drv_module_reload: Subgroup basic-reload-final: dmesg-warn -> PASS (fi-skl-6770hq) fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-bxt-t5700 total:79 pass:66 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:246 pass:218 dwarn:1 dfail:0 fail:0 skip:27 fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-ivb-3520m total:246 pass:224 dwarn:1 dfail:0 fail:0 skip:21 fi-ivb-3770 total:246 pass:224 dwarn:1 dfail:0 fail:0 skip:21 fi-kbl-7500u total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20 fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21 fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-snb-2520m total:246 pass:214 dwarn:1 dfail:0 fail:0 skip:31 fi-snb-2600 total:246 pass:213 dwarn:1 dfail:0 fail:0 skip:32 63217dc027c10b8e2788ba761339f07a4ba07cb8 drm-tip: 2017y-01m-19d-09h-31m-04s UTC integration manifest d99c4e9 drm: Show leaked connectors upon unload == Logs == For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3543/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm: Show leaked connectors upon unload 2017-01-19 11:24 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2017-01-19 11:32 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2017-01-19 11:32 UTC (permalink / raw) To: intel-gfx On Thu, Jan 19, 2017 at 11:24:24AM -0000, Patchwork wrote: > == Series Details == > > Series: drm: Show leaked connectors upon unload > URL : https://patchwork.freedesktop.org/series/18219/ > State : success > > == Summary == > > Series 18219v1 drm: Show leaked connectors upon unload > https://patchwork.freedesktop.org/api/1.0/series/18219/revisions/1/mbox/ > > Test drv_module_reload: > Subgroup basic-reload-final: > dmesg-warn -> PASS (fi-skl-6770hq) All cases appear to be: [drm:drm_mode_config_cleanup] *ERROR* connector VGA-1 leaked! -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Show leaked connectors upon unload 2017-01-19 9:05 [PATCH] drm: Show leaked connectors upon unload Chris Wilson 2017-01-19 11:24 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2017-01-19 13:36 ` Joonas Lahtinen 2017-01-19 14:17 ` Maarten Lankhorst 2 siblings, 0 replies; 8+ messages in thread From: Joonas Lahtinen @ 2017-01-19 13:36 UTC (permalink / raw) To: Chris Wilson, dri-devel; +Cc: intel-gfx On to, 2017-01-19 at 09:05 +0000, Chris Wilson wrote: > After warning that the connector list is not empty on device > unregistration (i.e. module unload) also print out which connectors are > still hanging around to aide finding the leak. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Show leaked connectors upon unload 2017-01-19 9:05 [PATCH] drm: Show leaked connectors upon unload Chris Wilson 2017-01-19 11:24 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-01-19 13:36 ` [PATCH] " Joonas Lahtinen @ 2017-01-19 14:17 ` Maarten Lankhorst 2017-01-23 10:06 ` Chris Wilson 2 siblings, 1 reply; 8+ messages in thread From: Maarten Lankhorst @ 2017-01-19 14:17 UTC (permalink / raw) To: Chris Wilson, dri-devel; +Cc: intel-gfx Op 19-01-17 om 10:05 schreef Chris Wilson: > After warning that the connector list is not empty on device > unregistration (i.e. module unload) also print out which connectors are > still hanging around to aide finding the leak. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/drm_mode_config.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > index ed1ee5a44a7b..884cc4d26fb5 100644 > --- a/drivers/gpu/drm/drm_mode_config.c > +++ b/drivers/gpu/drm/drm_mode_config.c > @@ -421,7 +421,12 @@ void drm_mode_config_cleanup(struct drm_device *dev) > drm_connector_unreference(connector); > } > drm_connector_list_iter_put(&conn_iter); > - WARN_ON(!list_empty(&dev->mode_config.connector_list)); > + if (WARN_ON(!list_empty(&dev->mode_config.connector_list))) { > + drm_connector_list_iter_get(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) > + DRM_ERROR("connector %s leaked!\n", connector->name); > + drm_connector_list_iter_put(&conn_iter); > + } > > list_for_each_entry_safe(property, pt, &dev->mode_config.property_list, > head) { Bikeshed perhaps, but maybe change to [CONNECTOR:%d:%s] connector leaked on cleanup? ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Show leaked connectors upon unload 2017-01-19 14:17 ` Maarten Lankhorst @ 2017-01-23 10:06 ` Chris Wilson 2017-01-23 10:12 ` Daniel Vetter 0 siblings, 1 reply; 8+ messages in thread From: Chris Wilson @ 2017-01-23 10:06 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: intel-gfx, dri-devel On Thu, Jan 19, 2017 at 03:17:36PM +0100, Maarten Lankhorst wrote: > Op 19-01-17 om 10:05 schreef Chris Wilson: > > After warning that the connector list is not empty on device > > unregistration (i.e. module unload) also print out which connectors are > > still hanging around to aide finding the leak. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > --- > > drivers/gpu/drm/drm_mode_config.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > index ed1ee5a44a7b..884cc4d26fb5 100644 > > --- a/drivers/gpu/drm/drm_mode_config.c > > +++ b/drivers/gpu/drm/drm_mode_config.c > > @@ -421,7 +421,12 @@ void drm_mode_config_cleanup(struct drm_device *dev) > > drm_connector_unreference(connector); > > } > > drm_connector_list_iter_put(&conn_iter); > > - WARN_ON(!list_empty(&dev->mode_config.connector_list)); > > + if (WARN_ON(!list_empty(&dev->mode_config.connector_list))) { > > + drm_connector_list_iter_get(dev, &conn_iter); > > + drm_for_each_connector_iter(connector, &conn_iter) > > + DRM_ERROR("connector %s leaked!\n", connector->name); > > + drm_connector_list_iter_put(&conn_iter); > > + } > > > > list_for_each_entry_safe(property, pt, &dev->mode_config.property_list, > > head) { > > Bikeshed perhaps, but maybe change to [CONNECTOR:%d:%s] connector leaked on cleanup? This patch isn't in my tree, so if a drm-misc maintainer would pick it and make the minor change, please do so :) -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Show leaked connectors upon unload 2017-01-23 10:06 ` Chris Wilson @ 2017-01-23 10:12 ` Daniel Vetter 2017-01-23 10:28 ` Chris Wilson 0 siblings, 1 reply; 8+ messages in thread From: Daniel Vetter @ 2017-01-23 10:12 UTC (permalink / raw) To: Chris Wilson, Maarten Lankhorst, dri-devel, intel-gfx On Mon, Jan 23, 2017 at 10:06:07AM +0000, Chris Wilson wrote: > On Thu, Jan 19, 2017 at 03:17:36PM +0100, Maarten Lankhorst wrote: > > Op 19-01-17 om 10:05 schreef Chris Wilson: > > > After warning that the connector list is not empty on device > > > unregistration (i.e. module unload) also print out which connectors are > > > still hanging around to aide finding the leak. > > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > --- > > > drivers/gpu/drm/drm_mode_config.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index ed1ee5a44a7b..884cc4d26fb5 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -421,7 +421,12 @@ void drm_mode_config_cleanup(struct drm_device *dev) > > > drm_connector_unreference(connector); > > > } > > > drm_connector_list_iter_put(&conn_iter); > > > - WARN_ON(!list_empty(&dev->mode_config.connector_list)); > > > + if (WARN_ON(!list_empty(&dev->mode_config.connector_list))) { > > > + drm_connector_list_iter_get(dev, &conn_iter); > > > + drm_for_each_connector_iter(connector, &conn_iter) > > > + DRM_ERROR("connector %s leaked!\n", connector->name); > > > + drm_connector_list_iter_put(&conn_iter); > > > + } > > > > > > list_for_each_entry_safe(property, pt, &dev->mode_config.property_list, > > > head) { > > > > Bikeshed perhaps, but maybe change to [CONNECTOR:%d:%s] connector leaked on cleanup? > > This patch isn't in my tree, so if a drm-misc maintainer would pick it > and make the minor change, please do so :) Hm, drm-misc maintainer picked it, but failed to do the minor bikeshed :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Show leaked connectors upon unload 2017-01-23 10:12 ` Daniel Vetter @ 2017-01-23 10:28 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2017-01-23 10:28 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx, dri-devel On Mon, Jan 23, 2017 at 11:12:31AM +0100, Daniel Vetter wrote: > On Mon, Jan 23, 2017 at 10:06:07AM +0000, Chris Wilson wrote: > > On Thu, Jan 19, 2017 at 03:17:36PM +0100, Maarten Lankhorst wrote: > > > Op 19-01-17 om 10:05 schreef Chris Wilson: > > > > After warning that the connector list is not empty on device > > > > unregistration (i.e. module unload) also print out which connectors are > > > > still hanging around to aide finding the leak. > > > > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > --- > > > > drivers/gpu/drm/drm_mode_config.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > > index ed1ee5a44a7b..884cc4d26fb5 100644 > > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > > @@ -421,7 +421,12 @@ void drm_mode_config_cleanup(struct drm_device *dev) > > > > drm_connector_unreference(connector); > > > > } > > > > drm_connector_list_iter_put(&conn_iter); > > > > - WARN_ON(!list_empty(&dev->mode_config.connector_list)); > > > > + if (WARN_ON(!list_empty(&dev->mode_config.connector_list))) { > > > > + drm_connector_list_iter_get(dev, &conn_iter); > > > > + drm_for_each_connector_iter(connector, &conn_iter) > > > > + DRM_ERROR("connector %s leaked!\n", connector->name); > > > > + drm_connector_list_iter_put(&conn_iter); > > > > + } > > > > > > > > list_for_each_entry_safe(property, pt, &dev->mode_config.property_list, > > > > head) { > > > > > > Bikeshed perhaps, but maybe change to [CONNECTOR:%d:%s] connector leaked on cleanup? > > > > This patch isn't in my tree, so if a drm-misc maintainer would pick it > > and make the minor change, please do so :) > > Hm, drm-misc maintainer picked it, but failed to do the minor bikeshed :( Ah, I was worried I had actually squashed it into a random patch and was starting to go mad. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-01-23 10:28 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-01-19 9:05 [PATCH] drm: Show leaked connectors upon unload Chris Wilson 2017-01-19 11:24 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-01-19 11:32 ` Chris Wilson 2017-01-19 13:36 ` [PATCH] " Joonas Lahtinen 2017-01-19 14:17 ` Maarten Lankhorst 2017-01-23 10:06 ` Chris Wilson 2017-01-23 10:12 ` Daniel Vetter 2017-01-23 10:28 ` Chris Wilson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.