Re: Filename too long

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2017-01-19 at 09:07 -0600, Mark Hatle wrote:
> On 1/19/17 4:21 AM, Richard Purdie wrote:
> > 
> > On Thu, 2017-01-19 at 14:13 +0800, Robert Yang wrote:
> > > 
> > Looking at the code in your patch, this second piece clearly isn't
> > true
> > due to this code:
> > 
> >           if gitsrcname.startswith('.'):
> >               gitsrcname = gitsrcname[1:]
> > 
> > I also don't believe this patch is correct since we're meant to be
> > creating a filename, not a path and if you leave the '/' characters
> > in,
> > it isn't a filename. I think we likely just need to truncate the
> > path
> > to the last say 225 chars if its over length. The unique piece
> > should
> > be towards the right hand end of the name.
> Ok.. I can certainly implement that.  Should the truncation be in the
> lockfile code or in the code that generatd the name itself?

Gut feeling says I think the generated name is safest.

Cheers,

Richard