* [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native
@ 2017-01-17 15:59 André Draszik
2017-01-17 16:42 ` Patrick Ohly
2017-01-23 10:58 ` André Draszik
0 siblings, 2 replies; 6+ messages in thread
From: André Draszik @ 2017-01-17 15:59 UTC (permalink / raw)
To: yocto
From: André Draszik <adraszik@tycoint.com>
The shell script uses time, which is either a bash built-in, or
a GNU utility. Not all build machines will have either bash or
GNU time available out of the box. Make sure it is available.
Note that this needs the patch to OE-core to enable the
time-native BBCLASSEXTEND to be applied before this here can
go in.
Signed-off-by: André Draszik <adraszik@tycoint.com>
---
classes/swupd-image.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/classes/swupd-image.bbclass b/classes/swupd-image.bbclass
index 5ba9cfb..60f7edb 100644
--- a/classes/swupd-image.bbclass
+++ b/classes/swupd-image.bbclass
@@ -563,6 +563,7 @@ SWUPDDEPENDS = "\
virtual/fakeroot-native:do_populate_sysroot \
rsync-native:do_populate_sysroot \
bsdiff-native:do_populate_sysroot \
+ time-native:do_populate_sysroot \
"
# We don't know exactly which formats will be in use during
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native
2017-01-17 15:59 [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native André Draszik
@ 2017-01-17 16:42 ` Patrick Ohly
2017-01-17 16:49 ` André Draszik
2017-01-23 10:58 ` André Draszik
1 sibling, 1 reply; 6+ messages in thread
From: Patrick Ohly @ 2017-01-17 16:42 UTC (permalink / raw)
To: André Draszik; +Cc: yocto
On Tue, 2017-01-17 at 15:59 +0000, André Draszik wrote:
> The shell script uses time, which is either a bash built-in, or
> a GNU utility. Not all build machines will have either bash or
> GNU time available out of the box. Make sure it is available.
Good catch. I'm just wondering whether it wouldn't be simpler to remove
the usage of "time" instead, or make it optional?
The "time" utility was useful while working on performance of the code,
but now that this is done, it's merely nice to have when one can get it
for free, which isn't the case when time-native has to be compiled
first.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native
2017-01-17 16:42 ` Patrick Ohly
@ 2017-01-17 16:49 ` André Draszik
2017-01-23 13:27 ` Patrick Ohly
0 siblings, 1 reply; 6+ messages in thread
From: André Draszik @ 2017-01-17 16:49 UTC (permalink / raw)
To: yocto
On Tue, 2017-01-17 at 17:42 +0100, Patrick Ohly wrote:
> On Tue, 2017-01-17 at 15:59 +0000, André Draszik wrote:
> > The shell script uses time, which is either a bash built-in, or
> > a GNU utility. Not all build machines will have either bash or
> > GNU time available out of the box. Make sure it is available.
>
> Good catch. I'm just wondering whether it wouldn't be simpler to remove
> the usage of "time" instead, or make it optional?
>
> The "time" utility was useful while working on performance of the code,
I thought the same, and was contemplating removing its use...
> but now that this is done, it's merely nice to have when one can get it
...but I was curious as well, so I left it in and added the dependency.
> for free, which isn't the case when time-native has to be compiled
> first.
It's a one-time host-depend, which should also be satisfied from sstate
after that, so I thought it'd be OK to keep it.
I have no preference either way.
Cheers,
Andre'
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native
2017-01-17 16:49 ` André Draszik
@ 2017-01-23 13:27 ` Patrick Ohly
2017-01-23 13:53 ` André Draszik
0 siblings, 1 reply; 6+ messages in thread
From: Patrick Ohly @ 2017-01-23 13:27 UTC (permalink / raw)
To: André Draszik; +Cc: yocto
On Tue, 2017-01-17 at 16:49 +0000, André Draszik wrote:
> I have no preference either way.
Let's remove the hard dependency. I've posted a "swupd-image.bbclass:
avoid depending on time command" patch which does that. Are you okay
with that?
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native
2017-01-17 15:59 [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native André Draszik
2017-01-17 16:42 ` Patrick Ohly
@ 2017-01-23 10:58 ` André Draszik
1 sibling, 0 replies; 6+ messages in thread
From: André Draszik @ 2017-01-23 10:58 UTC (permalink / raw)
To: yocto
On Tue, 2017-01-17 at 15:59 +0000, André Draszik wrote:
> Note that this needs the patch to OE-core to enable the
> time-native BBCLASSEXTEND to be applied before this here can
> go in.
The OE-core patch is in OE master now.
A.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-23 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 15:59 [meta-swupd][PATCH] swupd-image.bbclass: do_swupd_update() depends on time-native André Draszik
2017-01-17 16:42 ` Patrick Ohly
2017-01-17 16:49 ` André Draszik
2017-01-23 13:27 ` Patrick Ohly
2017-01-23 13:53 ` André Draszik
2017-01-23 10:58 ` André Draszik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.