[PATCH] xen: credit2: performance counter for load balancing call

[PATCH] xen: credit2: performance counter for load balancing call

[Praveen Kumar]

The patch introduces a new performance counter that keeps track of the load
balancing logic called in credit2 scheduler.

Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>

---
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index ef8e0d8..f212338 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -1869,6 +1869,8 @@ retry:
                     (unsigned char *)&d);
     }
 
+    SCHED_STAT_CRANK(acct_load_balance);
+
     /* Look for "swap" which gives the best load average
      * FIXME: O(n^2)! */
 
diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h
index 900fddd..0d702f0 100644
--- a/xen/include/xen/perfc_defn.h
+++ b/xen/include/xen/perfc_defn.h
@@ -57,6 +57,7 @@ PERFCOUNTER(vcpu_hot,               "csched: vcpu_hot")
 
 /* credit2 specific counters */
 PERFCOUNTER(burn_credits_t2c,       "csched2: burn_credits_t2c")
+PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
 PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
 PERFCOUNTER(upd_max_weight_full,    "csched2: update_max_weight_full")
 PERFCOUNTER(migrate_requested,      "csched2: migrate_requested")

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] xen: credit2: performance counter for load balancing call

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]

On Tue, 2017-01-24 at 23:23 +0530, Praveen Kumar wrote:
> The patch introduces a new performance counter that keeps track of
> the load
> balancing logic called in credit2 scheduler.
> 
I probably would have written "that counts how many time we go through
the load balancing logic in Credit2"

Or something like that.

But it's not a big deal, so, in any case:

> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
> 
Acked-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel