From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] clk: meson8b: fix clk81 register address
Date: Fri, 27 Jan 2017 09:43:53 +0100 [thread overview]
Message-ID: <1485506633.2442.9.camel@baylibre.com> (raw)
In-Reply-To: <20170126235745.GI8801@codeaurora.org>
On Thu, 2017-01-26 at 15:57 -0800, Stephen Boyd wrote:
> On 01/25, Jerome Brunet wrote:
> >
> > During meson8b clock probe, clk81 register address is fixed twice.
> > First using the meson8b_clk_gates array, then by directly changing
> > meson8b_clk81 register.
> >
> > As a result meson8b_clk81.reg = HHI_MPEG_CLK_CNTL + clk_base +
> > clk_base.
> >
> > Fixed by just removing the second fixup.
> >
> > Fixes: e31a1900c1ff ("meson: clk: Add support for clock gates")
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > ?Patch based on khilman/linux-amlogic.git master branch.
>
> The problem isn't introduced there though?
Indeed, I should have based my patch on clk-next. Will do next time.
>
> >
> >
> > ?I don't have a meson8b HW so this patch so this patch has not been
> > ?tested on real HW.
>
> Applied to clk-next.
>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: meson8b: fix clk81 register address
Date: Fri, 27 Jan 2017 09:43:53 +0100 [thread overview]
Message-ID: <1485506633.2442.9.camel@baylibre.com> (raw)
In-Reply-To: <20170126235745.GI8801@codeaurora.org>
On Thu, 2017-01-26 at 15:57 -0800, Stephen Boyd wrote:
> On 01/25, Jerome Brunet wrote:
> >
> > During meson8b clock probe, clk81 register address is fixed twice.
> > First using the meson8b_clk_gates array, then by directly changing
> > meson8b_clk81 register.
> >
> > As a result meson8b_clk81.reg = HHI_MPEG_CLK_CNTL + clk_base +
> > clk_base.
> >
> > Fixed by just removing the second fixup.
> >
> > Fixes: e31a1900c1ff ("meson: clk: Add support for clock gates")
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > Patch based on khilman/linux-amlogic.git master branch.
>
> The problem isn't introduced there though?
Indeed, I should have based my patch on clk-next. Will do next time.
>
> >
> >
> > I don't have a meson8b HW so this patch so this patch has not been
> > tested on real HW.
>
> Applied to clk-next.
>
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: meson8b: fix clk81 register address
Date: Fri, 27 Jan 2017 09:43:53 +0100 [thread overview]
Message-ID: <1485506633.2442.9.camel@baylibre.com> (raw)
In-Reply-To: <20170126235745.GI8801@codeaurora.org>
On Thu, 2017-01-26 at 15:57 -0800, Stephen Boyd wrote:
> On 01/25, Jerome Brunet wrote:
> >
> > During meson8b clock probe, clk81 register address is fixed twice.
> > First using the meson8b_clk_gates array, then by directly changing
> > meson8b_clk81 register.
> >
> > As a result meson8b_clk81.reg = HHI_MPEG_CLK_CNTL + clk_base +
> > clk_base.
> >
> > Fixed by just removing the second fixup.
> >
> > Fixes: e31a1900c1ff ("meson: clk: Add support for clock gates")
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > ?Patch based on khilman/linux-amlogic.git master branch.
>
> The problem isn't introduced there though?
Indeed, I should have based my patch on clk-next. Will do next time.
>
> >
> >
> > ?I don't have a meson8b HW so this patch so this patch has not been
> > ?tested on real HW.
>
> Applied to clk-next.
>
next prev parent reply other threads:[~2017-01-27 8:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 10:53 [PATCH] clk: meson8b: fix clk81 register address Jerome Brunet
2017-01-25 10:53 ` Jerome Brunet
2017-01-25 10:53 ` Jerome Brunet
2017-01-26 14:27 ` Jerome Brunet
2017-01-26 14:27 ` Jerome Brunet
2017-01-26 14:27 ` Jerome Brunet
2017-01-26 23:57 ` Stephen Boyd
2017-01-26 23:57 ` Stephen Boyd
2017-01-26 23:57 ` Stephen Boyd
2017-01-27 8:43 ` Jerome Brunet [this message]
2017-01-27 8:43 ` Jerome Brunet
2017-01-27 8:43 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485506633.2442.9.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.