All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Wed, 1 Feb 2017 17:52:30 +0000	[thread overview]
Message-ID: <1485971550.5515.34.camel@synopsys.com> (raw)
In-Reply-To: <0c458950-5558-0dc2-4323-c5faba757083@synopsys.com>

Hi Vineet,

On Wed, 2017-02-01@09:37 -0800, Vineet Gupta wrote:
> On 02/01/2017 09:14 AM, Alexey Brodkin wrote:
> > 
> > > 
> > > > 
> > > > -# CONFIG_ARC_TIMERS_64BIT is not set
> > > 
> > > Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> > > for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..
> > 
> > Not anymore :)
> > 
> > Probably I missed something in discussions.
> 
> STAR 9000879565, 9000879563
> 
> > 
> > As a matter of fact I did run-test resulting vmlinux and it worked very nice.
> > More over ARC_TIMERS_64BIT is selected automatically by ISA_ARCV2, see
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119
> > 
> > That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
> > effectively enabled, no?
> 
> The whole point of adding this to defconfig is to override the default from Kconfig ?

Not anymore :)

Since commit?c4c9a040ecb7 ("clocksource: import ARC timer driver"),
see?http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c4c9a040ecb7297e011e579f5a9cc280e42d725f
we have this:
---------------------->8----------------------
config ISA_ARCV2
	bool "ARC ISA v2"
	select ARC_TIMERS_64BIT
---------------------->8----------------------

which really means if one selects ISA_ARCV2 then ARC_TIMERS_64BIT gets selected automatically
and there's no way to override it from either menuconfig or defconfig.

Probably behavior that you meant was to keep a separate "config ARC_TIMERS_64BIT"
and have it "default y if ISA_ARCV2".

-Alexey

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Ruud Derwig <Ruud.Derwig@synopsys.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Wed, 1 Feb 2017 17:52:30 +0000	[thread overview]
Message-ID: <1485971550.5515.34.camel@synopsys.com> (raw)
In-Reply-To: <0c458950-5558-0dc2-4323-c5faba757083@synopsys.com>

Hi Vineet,

On Wed, 2017-02-01 at 09:37 -0800, Vineet Gupta wrote:
> On 02/01/2017 09:14 AM, Alexey Brodkin wrote:
> > 
> > > 
> > > > 
> > > > -# CONFIG_ARC_TIMERS_64BIT is not set
> > > 
> > > Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> > > for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..
> > 
> > Not anymore :)
> > 
> > Probably I missed something in discussions.
> 
> STAR 9000879565, 9000879563
> 
> > 
> > As a matter of fact I did run-test resulting vmlinux and it worked very nice.
> > More over ARC_TIMERS_64BIT is selected automatically by ISA_ARCV2, see
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119
> > 
> > That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
> > effectively enabled, no?
> 
> The whole point of adding this to defconfig is to override the default from Kconfig ?

Not anymore :)

Since commit c4c9a040ecb7 ("clocksource: import ARC timer driver"),
see http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c4c9a040ecb7297e011e579f5a9cc280e42d725f
we have this:
---------------------->8----------------------
config ISA_ARCV2
	bool "ARC ISA v2"
	select ARC_TIMERS_64BIT
---------------------->8----------------------

which really means if one selects ISA_ARCV2 then ARC_TIMERS_64BIT gets selected automatically
and there's no way to override it from either menuconfig or defconfig.

Probably behavior that you meant was to keep a separate "config ARC_TIMERS_64BIT"
and have it "default y if ISA_ARCV2".

-Alexey

  reply	other threads:[~2017-02-01 17:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 16:42 [PATCH 0/3] Updates for ARC VDK platform Alexey Brodkin
2017-02-01 16:42 ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:52   ` Vineet Gupta
2017-02-01 16:52     ` Vineet Gupta
2017-02-01 17:14     ` Alexey Brodkin
2017-02-01 17:14       ` Alexey Brodkin
2017-02-01 17:37       ` Vineet Gupta
2017-02-01 17:37         ` Vineet Gupta
2017-02-01 17:52         ` Alexey Brodkin [this message]
2017-02-01 17:52           ` Alexey Brodkin
2017-02-01 19:56           ` Vineet Gupta
2017-02-01 19:56             ` Vineet Gupta
2017-02-01 20:03             ` Alexey Brodkin
2017-02-01 20:03               ` Alexey Brodkin
2017-02-02 14:03             ` Ruud Derwig
2017-02-02 14:03               ` Ruud Derwig
2017-02-01 16:42 ` [PATCH 2/3] arc: vdk: Add support of MMC controller Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 3/3] arc: vdk: Add support of UIO Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 17:13 ` [PATCH 0/3] Updates for ARC VDK platform Vineet Gupta
2017-02-01 17:13   ` Vineet Gupta
2017-02-01 17:15   ` Alexey Brodkin
2017-02-01 17:15     ` Alexey Brodkin
2017-02-01 17:22     ` Vineet Gupta
2017-02-01 17:22       ` Vineet Gupta
2017-02-01 17:35       ` Alexey Brodkin
2017-02-01 17:35         ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485971550.5515.34.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.