From: Joe Perches <joe@perches.com>
To: Derek Robson <robsonde@gmail.com>, kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, w.d.hubbs@gmail.com, chris@the-brannons.com,
kirk@reisers.ca, samuel.thibault@ens-lyon.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
Date: Fri, 03 Feb 2017 20:21:42 -0800 [thread overview]
Message-ID: <1486182102.22276.76.camel@perches.com> (raw)
In-Reply-To: <20170204033129.GA28560@bigbird>
On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote:
> On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> > Hi Derek,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.10-rc6 next-20170203]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > All error/warnings (new ones prefixed by >>):
> >
> > #define param_check_int(name, p) __param_check(name, p, int)
> > ^~~~~~~~~~~~~
> > include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
> > param_check_##type(name, &(value)); \
> > ^~~~~~~~~~~~
> > drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> > module_param_named(ser, synth_acntsa.ser, int, 0444);
> > ^~~~~~~~~~~~~~~~~~
> > include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
> > param_check_##type(name, &(value)); \
> > ^
> > drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> > module_param_named(ser, synth_acntsa.ser, int, 0444);
> > ^~~~~~~~~~~~~~~~~~
> > include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
> > static const char __param_str_##name[] = prefix #name; \
>
> Can anyone tell me what I did wrong?
You removed semicolons from the function prototypes.
-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)
> I don't think it was my patch that broke the build.
You should make sure you build test a patch
before sending it on to the list.
next prev parent reply other threads:[~2017-02-04 4:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
2017-02-04 2:41 ` kbuild test robot
2017-02-04 3:31 ` Derek Robson
2017-02-04 4:21 ` Joe Perches [this message]
2017-02-04 2:53 ` kbuild test robot
2017-02-04 4:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486182102.22276.76.camel@perches.com \
--to=joe@perches.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robsonde@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.