All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Derek Robson <robsonde@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
	samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org,
	speakup@linux-speakup.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: Drivers: staging: speakup: spk_priv.h - style fix
Date: Fri, 3 Feb 2017 20:31:39 -0800	[thread overview]
Message-ID: <20170204043139.GA2260@roeck-us.net> (raw)
In-Reply-To: <20170203235641.10306-1-robsonde@gmail.com>

On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote:
> Changed function definition argument to have identifier name.
> found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/speakup/spk_priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
> index 98c4b6f0344a..1952d7887b3b 100644
> --- a/drivers/staging/speakup/spk_priv.h
> +++ b/drivers/staging/speakup/spk_priv.h
> @@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
>  int spk_synth_is_alive_nop(struct spk_synth *synth);
>  int spk_synth_is_alive_restart(struct spk_synth *synth);
>  void synth_printf(const char *buf, ...);
> -int synth_request_region(u_long, u_long);
> -int synth_release_region(u_long, u_long);
> +int synth_request_region(unsigned long start, unsigned long n)
> +int synth_release_region(unsigned long start, unsigned long n)

Hmmm .. you didn't compile test your code, did you ? 

You asked why 0day reports an error. If you compile this code,
I am quite sure that you are going to see the same errors.

Guenter

>  int synth_add(struct spk_synth *in_synth);
>  void synth_remove(struct spk_synth *in_synth);
>  

      parent reply	other threads:[~2017-02-04  4:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
2017-02-04  2:41 ` kbuild test robot
2017-02-04  3:31   ` Derek Robson
2017-02-04  4:21     ` Joe Perches
2017-02-04  2:53 ` kbuild test robot
2017-02-04  4:31 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170204043139.GA2260@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=chris@the-brannons.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robsonde@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.