All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] phy: meson8b-usb2: fix offsets for some of the registers
Date: Fri, 10 Feb 2017 10:27:54 +0100	[thread overview]
Message-ID: <1486718874.4693.31.camel@baylibre.com> (raw)
In-Reply-To: <20170113185358.8362-1-martin.blumenstingl@googlemail.com>

On Fri, 2017-01-13 at 19:53 +0100, Martin Blumenstingl wrote:
> The register offsets for REG_DBG_UART (and all following) were off by
> 0x4. This was not a problem yet because these registers are currently
> not used by the driver.
> 
> Signed-off-by: Martin Blumenstingl
> <martin.blumenstingl@googlemail.com>

Good catch ! Thx.

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
> ?drivers/phy/phy-meson8b-usb2.c | 6 +++---
> ?1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-
> meson8b-usb2.c
> index 33c9f4ba157d..30f56a6a411f 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -81,9 +81,9 @@
> ?	#define REG_ADP_BC_ACA_PIN_GND			BIT(25
> )
> ?	#define REG_ADP_BC_ACA_PIN_FLOAT		BIT(26)
> ?
> -#define REG_DBG_UART					0x14
> +#define REG_DBG_UART					0x10
> ?
> -#define REG_TEST					0x18
> +#define REG_TEST					0x14
> ?	#define REG_TEST_DATA_IN_MASK			GENMASK
> (3, 0)
> ?	#define REG_TEST_EN_MASK			GENMASK(7,
> 4)
> ?	#define REG_TEST_ADDR_MASK			GENMASK(11
> , 8)
> @@ -93,7 +93,7 @@
> ?	#define REG_TEST_DATA_OUT_MASK			GENMAS
> K(19, 16)
> ?	#define REG_TEST_DISABLE_ID_PULLUP		BIT(20)
> ?
> -#define REG_TUNE					0x1c
> +#define REG_TUNE					0x18
> ?	#define REG_TUNE_TX_RES_TUNE_MASK		GENMASK(1,
> 0)
> ?	#define REG_TUNE_TX_HSXV_TUNE_MASK		GENMASK(3,
> 2)
> ?	#define REG_TUNE_TX_VREF_TUNE_MASK		GENMASK(7,
> 4)

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: meson8b-usb2: fix offsets for some of the registers
Date: Fri, 10 Feb 2017 10:27:54 +0100	[thread overview]
Message-ID: <1486718874.4693.31.camel@baylibre.com> (raw)
In-Reply-To: <20170113185358.8362-1-martin.blumenstingl@googlemail.com>

On Fri, 2017-01-13 at 19:53 +0100, Martin Blumenstingl wrote:
> The register offsets for REG_DBG_UART (and all following) were off by
> 0x4. This was not a problem yet because these registers are currently
> not used by the driver.
> 
> Signed-off-by: Martin Blumenstingl
> <martin.blumenstingl@googlemail.com>

Good catch ! Thx.

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
> ?drivers/phy/phy-meson8b-usb2.c | 6 +++---
> ?1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-
> meson8b-usb2.c
> index 33c9f4ba157d..30f56a6a411f 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -81,9 +81,9 @@
> ?	#define REG_ADP_BC_ACA_PIN_GND			BIT(25
> )
> ?	#define REG_ADP_BC_ACA_PIN_FLOAT		BIT(26)
> ?
> -#define REG_DBG_UART					0x14
> +#define REG_DBG_UART					0x10
> ?
> -#define REG_TEST					0x18
> +#define REG_TEST					0x14
> ?	#define REG_TEST_DATA_IN_MASK			GENMASK
> (3, 0)
> ?	#define REG_TEST_EN_MASK			GENMASK(7,
> 4)
> ?	#define REG_TEST_ADDR_MASK			GENMASK(11
> , 8)
> @@ -93,7 +93,7 @@
> ?	#define REG_TEST_DATA_OUT_MASK			GENMAS
> K(19, 16)
> ?	#define REG_TEST_DISABLE_ID_PULLUP		BIT(20)
> ?
> -#define REG_TUNE					0x1c
> +#define REG_TUNE					0x18
> ?	#define REG_TUNE_TX_RES_TUNE_MASK		GENMASK(1,
> 0)
> ?	#define REG_TUNE_TX_HSXV_TUNE_MASK		GENMASK(3,
> 2)
> ?	#define REG_TUNE_TX_VREF_TUNE_MASK		GENMASK(7,
> 4)

  parent reply	other threads:[~2017-02-10  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
2017-01-13 18:53 ` Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
2017-02-03 20:05   ` Martin Blumenstingl
2017-02-10  9:27 ` Jerome Brunet [this message]
2017-02-10  9:27   ` Jerome Brunet
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
2017-03-04 10:20   ` Martin Blumenstingl
2017-03-24 19:19   ` Martin Blumenstingl
2017-03-24 19:19     ` Martin Blumenstingl
2017-03-27 10:06     ` Kishon Vijay Abraham I
2017-03-27 10:06       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486718874.4693.31.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.