From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] media: s5p_mfc print buf pointer in hex constistently
Date: Fri, 10 Feb 2017 10:59:15 -0800 [thread overview]
Message-ID: <1486753155.2192.13.camel@perches.com> (raw)
In-Reply-To: <20170210154053.23735-1-shuahkh@osg.samsung.com>
On Fri, 2017-02-10 at 08:40 -0700, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be
> consistent with the rest of the messages in the routine.
More curiously, why is buf_addr a size_t and not
a dma_addr_t?
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>
> Fixed commit log. No code changes. Thanks for the catch.
>
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been allocated.\n");
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com,
a.hajda@samsung.com, nicolas@ndufresne.ca, mchehab@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: s5p_mfc print buf pointer in hex constistently
Date: Fri, 10 Feb 2017 10:59:15 -0800 [thread overview]
Message-ID: <1486753155.2192.13.camel@perches.com> (raw)
In-Reply-To: <20170210154053.23735-1-shuahkh@osg.samsung.com>
On Fri, 2017-02-10 at 08:40 -0700, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be
> consistent with the rest of the messages in the routine.
More curiously, why is buf_addr a size_t and not
a dma_addr_t?
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>
> Fixed commit log. No code changes. Thanks for the catch.
>
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been allocated.\n");
next prev parent reply other threads:[~2017-02-10 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 15:40 [PATCH v2] media: s5p_mfc print buf pointer in hex constistently Shuah Khan
2017-02-10 15:40 ` Shuah Khan
2017-02-10 18:59 ` Joe Perches [this message]
2017-02-10 18:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486753155.2192.13.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.