From: Joe Perches <joe@perches.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>,
arnaud.patard@rtp-net.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name
Date: Tue, 14 Feb 2017 12:43:58 -0800 [thread overview]
Message-ID: <1487105038.6214.30.camel@perches.com> (raw)
In-Reply-To: <20170214203300.GA10308@arushi-HP-Pavilion-Notebook>
On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' should also have
> an identifier name.
[]
> diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
[]
> @@ -1,6 +1,6 @@
> #ifndef _VBINIT_
> #define _VBINIT_
> unsigned char XGIInitNew(struct pci_dev *pdev);
> -void XGIRegInit(struct vb_device_info *, unsigned long);
> +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);
Why do one argument but not the other?
next prev parent reply other threads:[~2017-02-14 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 20:33 [PATCH] staging: xgifb: function definition argument should also have an identifier name Arushi Singhal
2017-02-14 20:43 ` Joe Perches [this message]
[not found] ` <CA+XqjF-btw9=_jWVtdHDq9NSh5SizaZthuM4jsfWkXnRHfn9DQ@mail.gmail.com>
2017-02-15 3:38 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-02-15 8:31 Arushi Singhal
2017-02-16 18:30 ` Greg Kroah-Hartman
2017-02-16 19:17 Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487105038.6214.30.camel@perches.com \
--to=joe@perches.com \
--cc=arnaud.patard@rtp-net.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.