All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: alex.williamson@redhat.com, iommu@lists.linux-foundation.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] iommu: add warning when sharing groups
Date: Tue, 14 Feb 2017 16:25:22 -0500	[thread overview]
Message-ID: <1487107522-8695-2-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1487107522-8695-1-git-send-email-okaya@codeaurora.org>

The ACS requirement has been obscured in the current code and is only
known by certain individuals who happen to read the code. Print out a
warning with ACS path failure when ACS requirement is not met.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/iommu/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index dbe7f65..049ee0a 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -811,6 +811,9 @@ struct iommu_group *pci_device_group(struct device *dev)
 	if (IS_ERR(group))
 		return NULL;
 
+	if (pci_is_root_bus(bus))
+		dev_warn_once(&pdev->dev, "using shared group due to ACS path failure\n");
+
 	return group;
 }
 
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org,
	open list <linux-kernel@vger.kernel.org>,
	Sinan Kaya <okaya@codeaurora.org>,
	alex.williamson@redhat.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] iommu: add warning when sharing groups
Date: Tue, 14 Feb 2017 16:25:22 -0500	[thread overview]
Message-ID: <1487107522-8695-2-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1487107522-8695-1-git-send-email-okaya@codeaurora.org>

The ACS requirement has been obscured in the current code and is only
known by certain individuals who happen to read the code. Print out a
warning with ACS path failure when ACS requirement is not met.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/iommu/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index dbe7f65..049ee0a 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -811,6 +811,9 @@ struct iommu_group *pci_device_group(struct device *dev)
 	if (IS_ERR(group))
 		return NULL;
 
+	if (pci_is_root_bus(bus))
+		dev_warn_once(&pdev->dev, "using shared group due to ACS path failure\n");
+
 	return group;
 }
 
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] iommu: add warning when sharing groups
Date: Tue, 14 Feb 2017 16:25:22 -0500	[thread overview]
Message-ID: <1487107522-8695-2-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1487107522-8695-1-git-send-email-okaya@codeaurora.org>

The ACS requirement has been obscured in the current code and is only
known by certain individuals who happen to read the code. Print out a
warning with ACS path failure when ACS requirement is not met.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/iommu/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index dbe7f65..049ee0a 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -811,6 +811,9 @@ struct iommu_group *pci_device_group(struct device *dev)
 	if (IS_ERR(group))
 		return NULL;
 
+	if (pci_is_root_bus(bus))
+		dev_warn_once(&pdev->dev, "using shared group due to ACS path failure\n");
+
 	return group;
 }
 
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: alex.williamson@redhat.com, iommu@lists.linux-foundation.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/2] iommu: add warning when sharing groups
Date: Tue, 14 Feb 2017 16:25:22 -0500	[thread overview]
Message-ID: <1487107522-8695-2-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1487107522-8695-1-git-send-email-okaya@codeaurora.org>

The ACS requirement has been obscured in the current code and is only
known by certain individuals who happen to read the code. Print out a
warning with ACS path failure when ACS requirement is not met.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/iommu/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index dbe7f65..049ee0a 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -811,6 +811,9 @@ struct iommu_group *pci_device_group(struct device *dev)
 	if (IS_ERR(group))
 		return NULL;
 
+	if (pci_is_root_bus(bus))
+		dev_warn_once(&pdev->dev, "using shared group due to ACS path failure\n");
+
 	return group;
 }
 
-- 
1.9.1

  reply	other threads:[~2017-02-14 21:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 21:25 [PATCH 1/2] PCI: add QCOM root port quirks for ACS Sinan Kaya
2017-02-14 21:25 ` Sinan Kaya
2017-02-14 21:25 ` Sinan Kaya
2017-02-14 21:25 ` Sinan Kaya
2017-02-14 21:25 ` Sinan Kaya [this message]
2017-02-14 21:25   ` [PATCH 2/2] iommu: add warning when sharing groups Sinan Kaya
2017-02-14 21:25   ` Sinan Kaya
2017-02-14 21:25   ` Sinan Kaya
2017-02-14 23:51   ` Alex Williamson
2017-02-14 23:51     ` Alex Williamson
2017-02-14 23:51     ` Alex Williamson
     [not found]     ` <20170214165155.7c49485e-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2017-02-15  3:53       ` okaya-sgV2jX0FEOL9JmXXK+q4OQ
2017-02-15  3:53         ` okaya
2017-02-15  3:53         ` okaya at codeaurora.org
2017-02-15  3:53         ` okaya
2017-02-15 19:36         ` Alex Williamson
2017-02-15 19:36           ` Alex Williamson
2017-02-15 19:36           ` Alex Williamson
     [not found]           ` <20170215123613.1df4b33a-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2017-02-15 21:43             ` Sinan Kaya
2017-02-15 21:43               ` Sinan Kaya
2017-02-15 21:43               ` Sinan Kaya
2017-02-15 21:43               ` Sinan Kaya
2017-02-16 22:09               ` Sinan Kaya
2017-02-16 22:09                 ` Sinan Kaya
2017-02-16 22:09                 ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487107522-8695-2-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=alex.williamson@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.