All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Cc: Dave Gordon <david.s.gordon@intel.com>, stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.
Date: Wed, 15 Feb 2017 09:38:43 +0200	[thread overview]
Message-ID: <1487144323.8490.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170215041751.11441-1-kenneth@whitecape.org>

On ti, 2017-02-14 at 20:17 -0800, Kenneth Graunke wrote:
> This patch makes the I915_PARAM_HAS_EXEC_CONSTANTS getparam return 0
> (indicating the optional feature is not supported), and makes execbuf
> always return -EINVAL if the flags are used.
> 
> Apparently, no userspace ever shipped which used this optional feature:
> I checked the git history of Mesa, xf86-video-intel, libva, and Beignet,
> and there were zero commits showing a use of these flags.  Kernel commit
> 72bfa19c8deb4 apparently introduced the feature prematurely.
> 
> 'relative_constants_mode' has always been tracked per-device, but this
> has actually been wrong ever since hardware contexts were introduced, as
> the INSTPM register is saved (and automatically restored) as part of the
> render ring context. The software per-device value could therefore get
> out of sync with the hardware per-context value.  This meant that using
> them is actually unsafe: a client which tried to use them could damage
> the state of other clients, causing the GPU to interpret their BO
> offsets as absolute pointers, leading to bogus memory reads.
> 
> These flags were also never ported to execlist mode, making them no-ops
> on Gen9+ (which requires execlists), and Gen8 in the default mode.
> 
> On Gen8+, userspace can write these registers directly, achieving the
> same effect.  On Gen6-7.5, it likely makes sense to extend the command
> parser to support them.  I don't think anyone wants this on Gen4-5.
> 
> Based on a patch by Dave Gordon.
> 
> Cc: Dave Gordon <david.s.gordon@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92448
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>

Explanation makes sense, only Google hits seem to be on Mesa detecting
the feature and later, removing the detection when unused.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Cc: Dave Gordon <david.s.gordon@intel.com>, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.
Date: Wed, 15 Feb 2017 09:38:43 +0200	[thread overview]
Message-ID: <1487144323.8490.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170215041751.11441-1-kenneth@whitecape.org>

On ti, 2017-02-14 at 20:17 -0800, Kenneth Graunke wrote:
> This patch makes the I915_PARAM_HAS_EXEC_CONSTANTS getparam return 0
> (indicating the optional feature is not supported), and makes execbuf
> always return -EINVAL if the flags are used.
> 
> Apparently, no userspace ever shipped which used this optional feature:
> I checked the git history of Mesa, xf86-video-intel, libva, and Beignet,
> and there were zero commits showing a use of these flags.  Kernel commit
> 72bfa19c8deb4 apparently introduced the feature prematurely.
> 
> 'relative_constants_mode' has always been tracked per-device, but this
> has actually been wrong ever since hardware contexts were introduced, as
> the INSTPM register is saved (and automatically restored) as part of the
> render ring context. The software per-device value could therefore get
> out of sync with the hardware per-context value.  This meant that using
> them is actually unsafe: a client which tried to use them could damage
> the state of other clients, causing the GPU to interpret their BO
> offsets as absolute pointers, leading to bogus memory reads.
> 
> These flags were also never ported to execlist mode, making them no-ops
> on Gen9+ (which requires execlists), and Gen8 in the default mode.
> 
> On Gen8+, userspace can write these registers directly, achieving the
> same effect.  On Gen6-7.5, it likely makes sense to extend the command
> parser to support them.  I don't think anyone wants this on Gen4-5.
> 
> Based on a patch by Dave Gordon.
> 
> Cc: Dave Gordon <david.s.gordon@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92448
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>

Explanation makes sense, only Google hits seem to be on Mesa detecting
the feature and later, removing the detection when unused.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

  parent reply	other threads:[~2017-02-15  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  4:17 [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters Kenneth Graunke
2017-02-15  4:17 ` Kenneth Graunke
2017-02-15  4:52 ` ✓ Fi.CI.BAT: success for drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters. (rev2) Patchwork
2017-02-15  7:38 ` Joonas Lahtinen [this message]
2017-02-15  7:38   ` [Intel-gfx] [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters Joonas Lahtinen
2017-02-15  8:12 ` Chris Wilson
2017-02-15  9:33   ` Kenneth Graunke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487144323.8490.3.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kenneth@whitecape.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.