* [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
@ 2017-02-19 9:59 ` Aneesh Kumar K.V
0 siblings, 0 replies; 7+ messages in thread
From: Aneesh Kumar K.V @ 2017-02-19 9:59 UTC (permalink / raw)
To: akpm, Rik van Riel, Mel Gorman; +Cc: linux-mm, linux-kernel, Aneesh Kumar K.V
We are using wrong flag value in task_numa_falt function. This can result in
us doing wrong numa fault statistics update, because we update num_pages_migrate
and numa_fault_locality etc based on the flag argument passed.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 5f3ad65c85de..8f1d93257fb9 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
if (page_nid != -1)
task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
- vmf->flags);
+ flags);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
2017-02-19 9:59 ` Aneesh Kumar K.V
@ 2017-02-20 3:30 ` Hillf Danton
-1 siblings, 0 replies; 7+ messages in thread
From: Hillf Danton @ 2017-02-20 3:30 UTC (permalink / raw)
To: 'Aneesh Kumar K.V', akpm, 'Rik van Riel',
'Mel Gorman'
Cc: linux-mm, linux-kernel
On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote:
>
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
>
> if (page_nid != -1)
> task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> - vmf->flags);
> + flags);
>
> return 0;
> }
> --
> 2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
@ 2017-02-20 3:30 ` Hillf Danton
0 siblings, 0 replies; 7+ messages in thread
From: Hillf Danton @ 2017-02-20 3:30 UTC (permalink / raw)
To: 'Aneesh Kumar K.V', akpm, 'Rik van Riel',
'Mel Gorman'
Cc: linux-mm, linux-kernel
On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote:
>
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
>
> if (page_nid != -1)
> task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> - vmf->flags);
> + flags);
>
> return 0;
> }
> --
> 2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
2017-02-19 9:59 ` Aneesh Kumar K.V
(?)
(?)
@ 2017-02-20 13:57 ` Rik van Riel
-1 siblings, 0 replies; 7+ messages in thread
From: Rik van Riel @ 2017-02-20 13:57 UTC (permalink / raw)
To: Aneesh Kumar K.V, akpm, Mel Gorman; +Cc: linux-mm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Sun, 2017-02-19 at 15:29 +0530, Aneesh Kumar K.V wrote:
> We are using wrong flag value in task_numa_falt function. This can
> result in
> us doing wrong numa fault statistics update, because we update
> num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
2017-02-19 9:59 ` Aneesh Kumar K.V
@ 2017-02-23 9:42 ` Kirill A. Shutemov
-1 siblings, 0 replies; 7+ messages in thread
From: Kirill A. Shutemov @ 2017-02-23 9:42 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: akpm, Rik van Riel, Mel Gorman, linux-mm, linux-kernel
On Sun, Feb 19, 2017 at 03:29:55PM +0530, Aneesh Kumar K.V wrote:
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Ouch. My bad.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
@ 2017-02-23 9:42 ` Kirill A. Shutemov
0 siblings, 0 replies; 7+ messages in thread
From: Kirill A. Shutemov @ 2017-02-23 9:42 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: akpm, Rik van Riel, Mel Gorman, linux-mm, linux-kernel
On Sun, Feb 19, 2017 at 03:29:55PM +0530, Aneesh Kumar K.V wrote:
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Ouch. My bad.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 7+ messages in thread