* [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
@ 2017-02-13 9:54 ` Song Hongyan
0 siblings, 0 replies; 6+ messages in thread
From: Song Hongyan @ 2017-02-13 9:54 UTC (permalink / raw)
To: linux-input-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA
Cc: jikos-DgEjT+Ai2ygdnm+yROfE0A, jic23-DgEjT+Ai2ygdnm+yROfE0A,
srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w, Song Hongyan
Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
parsing, in case some implementation uses it as sensitivity modifier.
Signed-off-by: Song Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/iio/light/hid-sensor-prox.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index 45ca056..73fced8 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
st->common_attributes.sensitivity.index,
st->common_attributes.sensitivity.report_id);
}
+ if (st->common_attributes.sensitivity.index < 0)
+ sensor_hub_input_get_attribute_info(hsdev,
+ HID_FEATURE_REPORT, usage_id,
+ HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
+ HID_USAGE_SENSOR_HUMAN_PRESENCE,
+ &st->common_attributes.sensitivity);
+
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
@ 2017-02-13 9:54 ` Song Hongyan
0 siblings, 0 replies; 6+ messages in thread
From: Song Hongyan @ 2017-02-13 9:54 UTC (permalink / raw)
To: linux-input, linux-iio; +Cc: jikos, jic23, srinivas.pandruvada, Song Hongyan
Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
parsing, in case some implementation uses it as sensitivity modifier.
Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
drivers/iio/light/hid-sensor-prox.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index 45ca056..73fced8 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
st->common_attributes.sensitivity.index,
st->common_attributes.sensitivity.report_id);
}
+ if (st->common_attributes.sensitivity.index < 0)
+ sensor_hub_input_get_attribute_info(hsdev,
+ HID_FEATURE_REPORT, usage_id,
+ HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
+ HID_USAGE_SENSOR_HUMAN_PRESENCE,
+ &st->common_attributes.sensitivity);
+
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1486979692-44878-1-git-send-email-hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
2017-02-13 9:54 ` Song Hongyan
@ 2017-02-19 11:50 ` Jonathan Cameron
-1 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-02-19 11:50 UTC (permalink / raw)
To: Song Hongyan, linux-input-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA
Cc: jikos-DgEjT+Ai2ygdnm+yROfE0A,
srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w
On 13/02/17 09:54, Song Hongyan wrote:
> Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
> parsing, in case some implementation uses it as sensitivity modifier.
>
> Signed-off-by: Song Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Do we want to perhaps indicate to userspace in some way that this is what is being
reported? (not that I have any idea how a proximity sensor could potentially tell
a human from a passing cat for example ;)
Otherwise, I'm fine with this but would like an Ack from Srinivas.
> ---
> drivers/iio/light/hid-sensor-prox.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
> index 45ca056..73fced8 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
> st->common_attributes.sensitivity.index,
> st->common_attributes.sensitivity.report_id);
> }
> + if (st->common_attributes.sensitivity.index < 0)
> + sensor_hub_input_get_attribute_info(hsdev,
> + HID_FEATURE_REPORT, usage_id,
> + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> + HID_USAGE_SENSOR_HUMAN_PRESENCE,
> + &st->common_attributes.sensitivity);
> +
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
@ 2017-02-19 11:50 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-02-19 11:50 UTC (permalink / raw)
To: Song Hongyan, linux-input, linux-iio; +Cc: jikos, srinivas.pandruvada
On 13/02/17 09:54, Song Hongyan wrote:
> Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
> parsing, in case some implementation uses it as sensitivity modifier.
>
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
Do we want to perhaps indicate to userspace in some way that this is what is being
reported? (not that I have any idea how a proximity sensor could potentially tell
a human from a passing cat for example ;)
Otherwise, I'm fine with this but would like an Ack from Srinivas.
> ---
> drivers/iio/light/hid-sensor-prox.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
> index 45ca056..73fced8 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
> st->common_attributes.sensitivity.index,
> st->common_attributes.sensitivity.report_id);
> }
> + if (st->common_attributes.sensitivity.index < 0)
> + sensor_hub_input_get_attribute_info(hsdev,
> + HID_FEATURE_REPORT, usage_id,
> + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> + HID_USAGE_SENSOR_HUMAN_PRESENCE,
> + &st->common_attributes.sensitivity);
> +
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
2017-02-19 11:50 ` Jonathan Cameron
@ 2017-02-21 10:30 ` Pandruvada, Srinivas
-1 siblings, 0 replies; 6+ messages in thread
From: Pandruvada, Srinivas @ 2017-02-21 10:30 UTC (permalink / raw)
To: linux-input@vger.kernel.org, Song, Hongyan,
linux-iio@vger.kernel.org, jic23@kernel.org
Cc: jikos@kernel.org
On Sun, 2017-02-19 at 11:50 +0000, Jonathan Cameron wrote:
> On 13/02/17 09:54, Song Hongyan wrote:
> > Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence
> > sensitivity
> > parsing, in case some implementation uses it as sensitivity
> > modifier.
> >
> > Signed-off-by: Song Hongyan <hongyan.song@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> Do we want to perhaps indicate to userspace in some way that this is
> what is being
> reported? (not that I have any idea how a proximity sensor could
> potentially tell
> a human from a passing cat for example ;)
>
> Otherwise, I'm fine with this but would like an Ack from Srinivas.
> > ---
> > drivers/iio/light/hid-sensor-prox.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/iio/light/hid-sensor-prox.c
> > b/drivers/iio/light/hid-sensor-prox.c
> > index 45ca056..73fced8 100644
> > --- a/drivers/iio/light/hid-sensor-prox.c
> > +++ b/drivers/iio/light/hid-sensor-prox.c
> > @@ -240,6 +240,13 @@ static int prox_parse_report(struct
> > platform_device *pdev,
> > st->common_attributes.sensitivity.index,
> > st-
> > >common_attributes.sensitivity.report_id);
> > }
> > + if (st->common_attributes.sensitivity.index < 0)
> > + sensor_hub_input_get_attribute_info(hsdev,
> > + HID_FEATURE_REPORT, usage_id,
> > + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVI
> > TY_ABS |
> > + HID_USAGE_SENSOR_HUMAN_PRESENCE,
> > + &st->common_attributes.sensitivity);
> > +
> > return ret;
> > }
> >
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
@ 2017-02-21 10:30 ` Pandruvada, Srinivas
0 siblings, 0 replies; 6+ messages in thread
From: Pandruvada, Srinivas @ 2017-02-21 10:30 UTC (permalink / raw)
To: linux-input@vger.kernel.org, Song, Hongyan,
linux-iio@vger.kernel.org, jic23@kernel.org
Cc: jikos@kernel.org
T24gU3VuLCAyMDE3LTAyLTE5IGF0IDExOjUwICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiAxMy8wMi8xNyAwOTo1NCwgU29uZyBIb25neWFuIHdyb3RlOg0KPiA+IEFkZCBISURf
VVNBR0VfU0VOU09SX0hVTUFOX1BSRVNFTkNFIHN1cHBvcnQgZm9yIEh1bWFuIFByZXNlbmNlDQo+
ID4gc2Vuc2l0aXZpdHkNCj4gPiBwYXJzaW5nLCBpbiBjYXNlIHNvbWUgaW1wbGVtZW50YXRpb24g
dXNlcyBpdCBhcyBzZW5zaXRpdml0eQ0KPiA+IG1vZGlmaWVyLg0KPiA+IA0KPiA+IFNpZ25lZC1v
ZmYtYnk6IFNvbmcgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNvbT4NCkFja2VkLWJ5OiBT
cmluaXZhcyBQYW5kcnV2YWRhIDxzcmluaXZhcy5wYW5kcnV2YWRhQGxpbnV4LmludGVsLmNvbT4N
Cg0KPiANCj4gRG8gd2Ugd2FudCB0byBwZXJoYXBzIGluZGljYXRlIHRvIHVzZXJzcGFjZSBpbiBz
b21lIHdheSB0aGF0IHRoaXMgaXMNCj4gd2hhdCBpcyBiZWluZw0KPiByZXBvcnRlZD8gKG5vdCB0
aGF0IEkgaGF2ZSBhbnkgaWRlYSBob3cgYSBwcm94aW1pdHkgc2Vuc29yIGNvdWxkDQo+IHBvdGVu
dGlhbGx5IHRlbGwNCj4gYSBodW1hbiBmcm9tIGEgcGFzc2luZyBjYXQgZm9yIGV4YW1wbGUgOykN
Cj4gDQo+IE90aGVyd2lzZSwgSSdtIGZpbmUgd2l0aCB0aGlzIGJ1dCB3b3VsZCBsaWtlIGFuIEFj
ayBmcm9tIFNyaW5pdmFzLg0KPiA+IC0tLQ0KPiA+IMKgZHJpdmVycy9paW8vbGlnaHQvaGlkLXNl
bnNvci1wcm94LmMgfCA3ICsrKysrKysNCj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlv
bnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9paW8vbGlnaHQvaGlkLXNlbnNv
ci1wcm94LmMNCj4gPiBiL2RyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5zb3ItcHJveC5jDQo+ID4g
aW5kZXggNDVjYTA1Ni4uNzNmY2VkOCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2lpby9saWdo
dC9oaWQtc2Vuc29yLXByb3guYw0KPiA+ICsrKyBiL2RyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5z
b3ItcHJveC5jDQo+ID4gQEAgLTI0MCw2ICsyNDAsMTMgQEAgc3RhdGljIGludCBwcm94X3BhcnNl
X3JlcG9ydChzdHJ1Y3QNCj4gPiBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsDQo+ID4gwqAJCQlzdC0+
Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkuaW5kZXgsDQo+ID4gwqAJCQlzdC0NCj4gPiA+
Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkucmVwb3J0X2lkKTsNCj4gPiDCoAl9DQo+ID4g
KwlpZiAoc3QtPmNvbW1vbl9hdHRyaWJ1dGVzLnNlbnNpdGl2aXR5LmluZGV4IDwgMCkNCj4gPiAr
CQlzZW5zb3JfaHViX2lucHV0X2dldF9hdHRyaWJ1dGVfaW5mbyhoc2RldiwNCj4gPiArCQkJSElE
X0ZFQVRVUkVfUkVQT1JULCB1c2FnZV9pZCwNCj4gPiArCQkJSElEX1VTQUdFX1NFTlNPUl9EQVRB
X01PRF9DSEFOR0VfU0VOU0lUSVZJDQo+ID4gVFlfQUJTIHwNCj4gPiArCQkJSElEX1VTQUdFX1NF
TlNPUl9IVU1BTl9QUkVTRU5DRSwNCj4gPiArCQkJJnN0LT5jb21tb25fYXR0cmlidXRlcy5zZW5z
aXRpdml0eSk7DQo+ID4gKw0KPiA+IMKgCXJldHVybiByZXQ7DQo+ID4gwqB9DQo+ID4gwqANCj4g
PiANCj4gDQo+IA==
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-21 10:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-13 9:54 [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing Song Hongyan
2017-02-13 9:54 ` Song Hongyan
[not found] ` <1486979692-44878-1-git-send-email-hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-19 11:50 ` Jonathan Cameron
2017-02-19 11:50 ` Jonathan Cameron
2017-02-21 10:30 ` Pandruvada, Srinivas
2017-02-21 10:30 ` Pandruvada, Srinivas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.