All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic
Date: Tue, 21 Feb 2017 16:46:39 +0200	[thread overview]
Message-ID: <1487688399.3303.3.camel@gmail.com> (raw)
In-Reply-To: <1487688211.2614.39.camel@intel.com>

On Tue, 2017-02-21 at 11:43 -0300, Paulo Zanoni wrote:
> Em Ter, 2017-02-21 às 15:37 +0200, Ander Conselvan de Oliveira
> escreveu:
> > In the new atomic reality, the page flip in the end of the badstride
> > test succeeds. That flip is to an fb which has a stride too large to
> > allow FBC to be enabled. Adjust the test expections accordingly.
> 
> s/expections/expectations/

Fixed and pushed. 

Thanks,
Ander

> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> > 
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.olivei
> > ra@intel.com>
> > ---
> >  tests/kms_frontbuffer_tracking.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index 4f4848b..6d13e5d 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -3031,7 +3031,7 @@ static void badstride_subtest(const struct
> > test_mode *t)
> >  	 */
> >  	rc = drmModePageFlip(drm.fd, params->crtc_id, wide_fb.fb_id,
> > 0, NULL);
> >  	igt_assert(rc == -EINVAL || rc == 0);
> > -	do_assertions(0);
> > +	do_assertions(rc == 0 ? ASSERT_FBC_DISABLED : 0);
> >  
> >  	igt_remove_fb(drm.fd, &wide_fb);
> >  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2017-02-21 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 13:37 [PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic Ander Conselvan de Oliveira
2017-02-21 14:43 ` Paulo Zanoni
2017-02-21 14:46   ` Ander Conselvan De Oliveira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487688399.3303.3.camel@gmail.com \
    --to=conselvan2@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.