[PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic

[PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic

[Ander Conselvan de Oliveira]

In the new atomic reality, the page flip in the end of the badstride
test succeeds. That flip is to an fb which has a stride too large to
allow FBC to be enabled. Adjust the test expections accordingly.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 4f4848b..6d13e5d 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -3031,7 +3031,7 @@ static void badstride_subtest(const struct test_mode *t)
 	 */
 	rc = drmModePageFlip(drm.fd, params->crtc_id, wide_fb.fb_id, 0, NULL);
 	igt_assert(rc == -EINVAL || rc == 0);
-	do_assertions(0);
+	do_assertions(rc == 0 ? ASSERT_FBC_DISABLED : 0);
 
 	igt_remove_fb(drm.fd, &wide_fb);
 }
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic

[Paulo Zanoni]

Em Ter, 2017-02-21 às 15:37 +0200, Ander Conselvan de Oliveira
escreveu:
> In the new atomic reality, the page flip in the end of the badstride
> test succeeds. That flip is to an fb which has a stride too large to
> allow FBC to be enabled. Adjust the test expections accordingly.

s/expections/expectations/

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.olivei
> ra@intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index 4f4848b..6d13e5d 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -3031,7 +3031,7 @@ static void badstride_subtest(const struct
> test_mode *t)
>  	 */
>  	rc = drmModePageFlip(drm.fd, params->crtc_id, wide_fb.fb_id,
> 0, NULL);
>  	igt_assert(rc == -EINVAL || rc == 0);
> -	do_assertions(0);
> +	do_assertions(rc == 0 ? ASSERT_FBC_DISABLED : 0);
>  
>  	igt_remove_fb(drm.fd, &wide_fb);
>  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] kms_frontbuffer_tracking: Fix badstride test skipping with atomic

[Ander Conselvan De Oliveira]

On Tue, 2017-02-21 at 11:43 -0300, Paulo Zanoni wrote:
> Em Ter, 2017-02-21 às 15:37 +0200, Ander Conselvan de Oliveira
> escreveu:
> > In the new atomic reality, the page flip in the end of the badstride
> > test succeeds. That flip is to an fb which has a stride too large to
> > allow FBC to be enabled. Adjust the test expections accordingly.
> 
> s/expections/expectations/

Fixed and pushed. 

Thanks,
Ander

> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> > 
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.olivei
> > ra@intel.com>
> > ---
> >  tests/kms_frontbuffer_tracking.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index 4f4848b..6d13e5d 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -3031,7 +3031,7 @@ static void badstride_subtest(const struct
> > test_mode *t)
> >  	 */
> >  	rc = drmModePageFlip(drm.fd, params->crtc_id, wide_fb.fb_id,
> > 0, NULL);
> >  	igt_assert(rc == -EINVAL || rc == 0);
> > -	do_assertions(0);
> > +	do_assertions(rc == 0 ? ASSERT_FBC_DISABLED : 0);
> >  
> >  	igt_remove_fb(drm.fd, &wide_fb);
> >  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx