From: Jonathan Dieter <jdieter@lesbg.com>
To: Krzysztof Opasiak <k.opasiak@samsung.com>, linux-kernel@vger.kernel.org
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB OVER IP DRIVER" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] usbip: Fix-format-overflow
Date: Wed, 22 Feb 2017 20:14:25 +0200 [thread overview]
Message-ID: <1487787265.13719.10.camel@lesbg.com> (raw)
In-Reply-To: <d129d7da-f98d-6bc5-399e-7432b75cd6ad@samsung.com>
On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
<snip>
> > char busid[SYSFS_BUS_ID_SIZE];
> > + unsigned int size;
>
> I'm not really convinced to use unsigned here. snprintf() is declared
> to
> return signed integer so we should assume that some of its
> implementation may return negative error code. Any rationale to this
> instead of just doing a cast for comparsion but signed value to print
> error?
No, you're absolutely right. I've fixed this and am sending the next
revision now.
Jonathan
next prev parent reply other threads:[~2017-02-22 18:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170220205937epcas3p4e334a658cf4d67f4a7d5a4ae7ce10afc@epcas3p4.samsung.com>
2017-02-20 20:51 ` [PATCH 1/2] Fix format overflows Jonathan Dieter
2017-02-20 20:51 ` [PATCH 2/2] Fix implicit fallthrough warning Jonathan Dieter
2017-02-21 6:12 ` [PATCH 1/2] Fix format overflows Krzysztof Opasiak
2017-02-21 6:48 ` Jonathan Dieter
2017-02-21 17:50 ` Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-22 5:49 ` [PATCH v2 1/2] usbip: Fix-format-overflow Krzysztof Opasiak
2017-02-22 18:14 ` Jonathan Dieter [this message]
2017-02-22 18:17 ` [PATCH v3 " Jonathan Dieter
2017-02-22 18:18 ` [PATCH v3 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-03-16 7:47 ` [PATCH v4 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-03-16 15:04 ` Shuah Khan
2017-03-17 1:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487787265.13719.10.camel@lesbg.com \
--to=jdieter@lesbg.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.opasiak@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.