From: Jonathan Dieter <jdieter@lesbg.com>
To: linux-kernel@vger.kernel.org
Cc: Jonathan Dieter <jdieter@lesbg.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Peter Senna Tschudin <peter.senna@gmail.com>,
linux-usb@vger.kernel.org (open list:USB OVER IP DRIVER)
Subject: [PATCH 2/2] Fix implicit fallthrough warning
Date: Mon, 20 Feb 2017 22:51:24 +0200 [thread overview]
Message-ID: <20170220205129.18194-2-jdieter@lesbg.com> (raw)
In-Reply-To: <20170220205129.18194-1-jdieter@lesbg.com>
GCC 7 now warns when switch statements fall through implicitly, and with
-Werror enabled in configure.ac, that makes these tools unbuildable.
We fix this by notifying the compiler that this particular case statement
is meant to fall through.
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char *argv[])
break;
case '?':
printf("usbip: invalid option\n");
+ /* Terminate after printing error */
+ /* FALLTHRU */
default:
usbip_usage();
goto out;
--
2.9.3
next prev parent reply other threads:[~2017-02-20 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170220205937epcas3p4e334a658cf4d67f4a7d5a4ae7ce10afc@epcas3p4.samsung.com>
2017-02-20 20:51 ` [PATCH 1/2] Fix format overflows Jonathan Dieter
2017-02-20 20:51 ` Jonathan Dieter [this message]
2017-02-21 6:12 ` Krzysztof Opasiak
2017-02-21 6:48 ` Jonathan Dieter
2017-02-21 17:50 ` Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-22 5:49 ` [PATCH v2 1/2] usbip: Fix-format-overflow Krzysztof Opasiak
2017-02-22 18:14 ` Jonathan Dieter
2017-02-22 18:17 ` [PATCH v3 " Jonathan Dieter
2017-02-22 18:18 ` [PATCH v3 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-03-16 7:47 ` [PATCH v4 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-03-16 15:04 ` Shuah Khan
2017-03-17 1:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220205129.18194-2-jdieter@lesbg.com \
--to=jdieter@lesbg.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.