From: Dalon Westergreen <dwesterg@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] common: image: update boot_get_fpga to support arbitrary fpga image
Date: Fri, 24 Feb 2017 08:48:49 -0800 [thread overview]
Message-ID: <1487954929.6827.14.camel@gmail.com> (raw)
In-Reply-To: <CAPnjgZ1cT02gjrqKQdfWCW5+0Y-k6JMB7m55PZYrD=CfjjRd4Q@mail.gmail.com>
On Tue, 2017-02-21 at 21:00 -0700, Simon Glass wrote:
> Hi Dalon,
>
> On 20 February 2017 at 07:56, Dalon Westergreen <dwesterg@gmail.com> wrote:
> >
> > The implementation of boot_get_fpga only supported one fpga family.
> > This modification allows for any of the fpga devices supported by
> > fpga_load to be used.
>
[snip ...]
> >
> > ?/* configuration node */
> > ?#define FIT_KERNEL_PROP????????????????"kernel"
> > @@ -955,6 +957,9 @@ int fit_image_hash_get_value(const void *fit, int
> > noffset, uint8_t **value,
> >
> > ?int fit_set_timestamp(void *fit, int noffset, time_t timestamp);
> >
> > +int fit_image_fpga_get_devnum(const void *fit, int noffset, int *devnum);
> > +int fit_image_fpga_is_partial(const void *fit, int noffset);
>
> Can you put the function comments here instead of in the C file?
Doing this would be counter to every other function in the c file these
are added to, so i think it best to leave as is.
--dalon
> >
> > +
> > ?/**
> > ? * fit_add_verification_data() - add verification data to FIT image nodes
> > ? *
> > --
> > 2.7.4
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
> Regards,
> Simon
next prev parent reply other threads:[~2017-02-24 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 14:56 [U-Boot] [PATCH v3 0/2] common: fitimage support for arbitrary fpga type Dalon Westergreen
2017-02-20 14:56 ` [U-Boot] [PATCH v3 1/2] common: image: update boot_get_fpga to support arbitrary fpga image Dalon Westergreen
2017-02-20 15:16 ` Michal Simek
2017-02-20 15:46 ` Dalon Westergreen
2017-02-21 12:21 ` Michal Simek
2017-02-22 4:00 ` Simon Glass
2017-02-22 12:08 ` Tomas Melin
2017-02-22 14:26 ` Dalon Westergreen
2017-02-22 14:22 ` Dalon Westergreen
2017-02-24 16:48 ` Dalon Westergreen [this message]
2017-02-20 14:56 ` [U-Boot] [PATCH v3 2/2] common: bootm: add support for arbitrary fgpa configuration Dalon Westergreen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487954929.6827.14.camel@gmail.com \
--to=dwesterg@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.