From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Soren Brinkmann" <soren.brinkmann@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
devicetree@vger.kernel.org,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Ola Jeppson" <ola@adapteva.com>,
linux-usb@vger.kernel.org,
"Michal Simek" <michal.simek@xilinx.com>,
"Felipe Balbi" <balbi@ti.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset
Date: Tue, 27 Jan 2015 16:24:10 +0100 [thread overview]
Message-ID: <1488241.JRB4nxvr9q@wuerfel> (raw)
In-Reply-To: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com>
On Monday 26 January 2015 17:45:29 Soren Brinkmann wrote:
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
> index dd05254241fb..a73d4c738f0b 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
>
> if (err == -EPROBE_DEFER)
> return -EPROBE_DEFER;
> - if (err) {
> - dev_err(dev, "Error requesting RESET GPIO\n");
> - return err;
> - }
> + if (err)
> + nop->gpiod_reset = NULL;
You might want to distinguish between a missing property and a
reset gpio that was specified but for some reason cannot be used.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: phy-generic: Don't fail on missing gpio reset
Date: Tue, 27 Jan 2015 16:24:10 +0100 [thread overview]
Message-ID: <1488241.JRB4nxvr9q@wuerfel> (raw)
In-Reply-To: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com>
On Monday 26 January 2015 17:45:29 Soren Brinkmann wrote:
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
> index dd05254241fb..a73d4c738f0b 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
>
> if (err == -EPROBE_DEFER)
> return -EPROBE_DEFER;
> - if (err) {
> - dev_err(dev, "Error requesting RESET GPIO\n");
> - return err;
> - }
> + if (err)
> + nop->gpiod_reset = NULL;
You might want to distinguish between a missing property and a
reset gpio that was specified but for some reason cannot be used.
Arnd
next prev parent reply other threads:[~2015-01-27 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 1:45 [PATCH] usb: phy-generic: Don't fail on missing gpio reset Soren Brinkmann
2015-01-27 1:45 ` Soren Brinkmann
2015-01-27 15:20 ` Felipe Balbi
2015-01-27 15:20 ` Felipe Balbi
2015-01-27 19:13 ` Sören Brinkmann
2015-01-27 19:13 ` Sören Brinkmann
2015-01-27 19:13 ` Sören Brinkmann
2015-01-27 19:14 ` Felipe Balbi
2015-01-27 19:14 ` Felipe Balbi
2015-01-27 15:24 ` Arnd Bergmann [this message]
2015-01-27 15:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488241.JRB4nxvr9q@wuerfel \
--to=arnd@arndb.de \
--cc=afaerber@suse.de \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ola@adapteva.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.