diff for duplicates of <1488296129.3056.1.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 134cb09..dce0820 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,26 @@ -T24gVHVlLCAyMDE3LTAyLTI4IGF0IDE1OjAyICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K -PiBCaXR3aXNlICYgd2FzIG9idmlvdXNseSBpbnRlbmRlZCBoZXJlLg0KPiANCj4gRml4ZXM6IDc0 -NWQ4YWU0NjIyYyAoIm5ldC9tbHg0OiBTcG9vZmNoZWNrIGFuZCB6ZXJvIE1BQyBjYW4ndCBjb2V4 -aXN0IikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFj -bGUuY29tPg0KPiAtLS0NCj4gQXBwbGllcyB0byBuZXQuZ2l0Lg0KPiANCj4gZGlmZiAtLWdpdCBh -L2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIuaCBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIu -aA0KPiBpbmRleCBlOTY1ZTUwOTBkOTYuLmE4NThiY2I2MjIwYiAxMDA2NDQNCj4gLS0tIGEvaW5j -bHVkZS9saW51eC9tbHg0L2RyaXZlci5oDQo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2 -ZXIuaA0KPiBAQCAtMTA5LDcgKzEwOSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBtbHg0X3U2NF90 -b19tYWModTggKmFkZHIsIHU2NCBtYWMpDQo+ICAJaW50IGk7DQo+ICANCj4gIAlmb3IgKGkgPSBF -VEhfQUxFTjsgaSA+IDA7IGktLSkgew0KPiAtCQlhZGRyW2kgLSAxXSA9IG1hYyAmJiAweEZGOw0K -PiArCQlhZGRyW2kgLSAxXSA9IG1hYyAmIDB4RkY7DQo+ICAJCW1hYyA+Pj0gODsNCj4gIAl9DQo+ -ICB9DQoNCklzIHRoaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgc3VjaCBhIGxvb3Agb2NjdXJzPyBT -aG91bGQgYSBwdXRfdW5hbGlnbmVkX2JlNDgoKQ0KZnVuY3Rpb24gYmUgaW50cm9kdWNlZD8NCg0K -QmFydC4 +On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote: +> Bitwise & was obviously intended here. +> +> Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist") +> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> --- +> Applies to net.git. +> +> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h +> index e965e5090d96..a858bcb6220b 100644 +> --- a/include/linux/mlx4/driver.h +> +++ b/include/linux/mlx4/driver.h +> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac) +> int i; +> +> for (i = ETH_ALEN; i > 0; i--) { +> - addr[i - 1] = mac && 0xFF; +> + addr[i - 1] = mac & 0xFF; +> mac >>= 8; +> } +> } + +Is this the only place where such a loop occurs? Should a put_unaligned_be48() +function be introduced? + +Bart. diff --git a/a/content_digest b/N1/content_digest index d2eaee5..bba7f6c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,5 +1,5 @@ "ref\020170228120215.GA27947@mwanda\0" - "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" + "From\0Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>\0" "Subject\0Re: [patch] net/mlx4: && vs & typo\0" "Date\0Tue, 28 Feb 2017 15:35:44 +0000\0" "To\0eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org <eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>" @@ -10,20 +10,31 @@ " kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDE3LTAyLTI4IGF0IDE1OjAyICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K\n" - "PiBCaXR3aXNlICYgd2FzIG9idmlvdXNseSBpbnRlbmRlZCBoZXJlLg0KPiANCj4gRml4ZXM6IDc0\n" - "NWQ4YWU0NjIyYyAoIm5ldC9tbHg0OiBTcG9vZmNoZWNrIGFuZCB6ZXJvIE1BQyBjYW4ndCBjb2V4\n" - "aXN0IikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFj\n" - "bGUuY29tPg0KPiAtLS0NCj4gQXBwbGllcyB0byBuZXQuZ2l0Lg0KPiANCj4gZGlmZiAtLWdpdCBh\n" - "L2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIuaCBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIu\n" - "aA0KPiBpbmRleCBlOTY1ZTUwOTBkOTYuLmE4NThiY2I2MjIwYiAxMDA2NDQNCj4gLS0tIGEvaW5j\n" - "bHVkZS9saW51eC9tbHg0L2RyaXZlci5oDQo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2\n" - "ZXIuaA0KPiBAQCAtMTA5LDcgKzEwOSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBtbHg0X3U2NF90\n" - "b19tYWModTggKmFkZHIsIHU2NCBtYWMpDQo+ICAJaW50IGk7DQo+ICANCj4gIAlmb3IgKGkgPSBF\n" - "VEhfQUxFTjsgaSA+IDA7IGktLSkgew0KPiAtCQlhZGRyW2kgLSAxXSA9IG1hYyAmJiAweEZGOw0K\n" - "PiArCQlhZGRyW2kgLSAxXSA9IG1hYyAmIDB4RkY7DQo+ICAJCW1hYyA+Pj0gODsNCj4gIAl9DQo+\n" - "ICB9DQoNCklzIHRoaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgc3VjaCBhIGxvb3Agb2NjdXJzPyBT\n" - "aG91bGQgYSBwdXRfdW5hbGlnbmVkX2JlNDgoKQ0KZnVuY3Rpb24gYmUgaW50cm9kdWNlZD8NCg0K\n" - QmFydC4 + "On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote:\n" + "> Bitwise & was obviously intended here.\n" + "> \n" + "> Fixes: 745d8ae4622c (\"net/mlx4: Spoofcheck and zero MAC can't coexist\")\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> ---\n" + "> Applies to net.git.\n" + "> \n" + "> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h\n" + "> index e965e5090d96..a858bcb6220b 100644\n" + "> --- a/include/linux/mlx4/driver.h\n" + "> +++ b/include/linux/mlx4/driver.h\n" + "> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)\n" + "> \tint i;\n" + "> \n" + "> \tfor (i = ETH_ALEN; i > 0; i--) {\n" + "> -\t\taddr[i - 1] = mac && 0xFF;\n" + "> +\t\taddr[i - 1] = mac & 0xFF;\n" + "> \t\tmac >>= 8;\n" + "> \t}\n" + "> }\n" + "\n" + "Is this the only place where such a loop occurs? Should a put_unaligned_be48()\n" + "function be introduced?\n" + "\n" + Bart. -f0800f5c1cf895fe70638a81da7dbba791b2a2f03f607be1550b7d9969d82de6 +45ed19095b2dcc17879e460310f0e27b4b304dbbd29d83e9459738fae7ec6fc2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.