From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [patch] net/mlx4: && vs & typo
Date: Tue, 28 Feb 2017 15:35:44 +0000 [thread overview]
Message-ID: <1488296129.3056.1.camel@sandisk.com> (raw)
In-Reply-To: <20170228120215.GA27947@mwanda>
T24gVHVlLCAyMDE3LTAyLTI4IGF0IDE1OjAyICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K
PiBCaXR3aXNlICYgd2FzIG9idmlvdXNseSBpbnRlbmRlZCBoZXJlLg0KPiANCj4gRml4ZXM6IDc0
NWQ4YWU0NjIyYyAoIm5ldC9tbHg0OiBTcG9vZmNoZWNrIGFuZCB6ZXJvIE1BQyBjYW4ndCBjb2V4
aXN0IikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFj
bGUuY29tPg0KPiAtLS0NCj4gQXBwbGllcyB0byBuZXQuZ2l0Lg0KPiANCj4gZGlmZiAtLWdpdCBh
L2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIuaCBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2ZXIu
aA0KPiBpbmRleCBlOTY1ZTUwOTBkOTYuLmE4NThiY2I2MjIwYiAxMDA2NDQNCj4gLS0tIGEvaW5j
bHVkZS9saW51eC9tbHg0L2RyaXZlci5oDQo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWx4NC9kcml2
ZXIuaA0KPiBAQCAtMTA5LDcgKzEwOSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBtbHg0X3U2NF90
b19tYWModTggKmFkZHIsIHU2NCBtYWMpDQo+ICAJaW50IGk7DQo+ICANCj4gIAlmb3IgKGkgPSBF
VEhfQUxFTjsgaSA+IDA7IGktLSkgew0KPiAtCQlhZGRyW2kgLSAxXSA9IG1hYyAmJiAweEZGOw0K
PiArCQlhZGRyW2kgLSAxXSA9IG1hYyAmIDB4RkY7DQo+ICAJCW1hYyA+Pj0gODsNCj4gIAl9DQo+
ICB9DQoNCklzIHRoaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgc3VjaCBhIGxvb3Agb2NjdXJzPyBT
aG91bGQgYSBwdXRfdW5hbGlnbmVkX2JlNDgoKQ0KZnVuY3Rpb24gYmUgaW50cm9kdWNlZD8NCg0K
QmFydC4
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [patch] net/mlx4: && vs & typo
Date: Tue, 28 Feb 2017 15:35:44 +0000 [thread overview]
Message-ID: <1488296129.3056.1.camel@sandisk.com> (raw)
In-Reply-To: <20170228120215.GA27947@mwanda>
On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote:
> Bitwise & was obviously intended here.
>
> Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Applies to net.git.
>
> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h
> index e965e5090d96..a858bcb6220b 100644
> --- a/include/linux/mlx4/driver.h
> +++ b/include/linux/mlx4/driver.h
> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)
> int i;
>
> for (i = ETH_ALEN; i > 0; i--) {
> - addr[i - 1] = mac && 0xFF;
> + addr[i - 1] = mac & 0xFF;
> mac >>= 8;
> }
> }
Is this the only place where such a loop occurs? Should a put_unaligned_be48()
function be introduced?
Bart.
next prev parent reply other threads:[~2017-02-28 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 12:02 [patch] net/mlx4: && vs & typo Dan Carpenter
2017-02-28 12:02 ` Dan Carpenter
2017-02-28 15:35 ` Bart Van Assche [this message]
2017-02-28 15:35 ` Bart Van Assche
[not found] ` <1488296129.3056.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-02-28 22:23 ` Joe Perches
2017-02-28 22:23 ` Joe Perches
2017-02-28 22:45 ` Bart Van Assche
2017-02-28 22:45 ` Bart Van Assche
2017-03-01 6:52 ` Julia Lawall
2017-03-01 6:52 ` Julia Lawall
2017-03-01 8:34 ` Tariq Toukan
2017-03-01 8:34 ` Tariq Toukan
2017-02-28 16:53 ` Tariq Toukan
2017-02-28 16:53 ` Tariq Toukan
2017-02-28 16:53 ` Tariq Toukan
2017-03-01 17:52 ` David Miller
2017-03-01 17:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488296129.3056.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=eugenia-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.