From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] clk: meson: fix SET_PARM macro
Date: Tue, 28 Feb 2017 22:41:30 +0100 [thread overview]
Message-ID: <1488318090.21996.2.camel@baylibre.com> (raw)
In-Reply-To: <20170228212654.GM25384@codeaurora.org>
On Tue, 2017-02-28 at 13:26 -0800, Stephen Boyd wrote:
> On 02/28, Jerome Brunet wrote:
> > parameter val is not enclosed in parenthesis which is buggy when
> > given an
> > expression instead of a simple value
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Fixes tag? Is there a place in the code that is using a complex
> expression for val right now?
>
Not if with what's already in, afaik. However "clk: meson: mpll: add rw
operation" I sent earlier today uses a ternary operator for val.
That's??how I found this issue. Instead of running the test, it would
always use the "else" clause.
I realize I should sent these patches in the same series.
Would you prefer me to do so ?
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: meson: fix SET_PARM macro
Date: Tue, 28 Feb 2017 22:41:30 +0100 [thread overview]
Message-ID: <1488318090.21996.2.camel@baylibre.com> (raw)
In-Reply-To: <20170228212654.GM25384@codeaurora.org>
On Tue, 2017-02-28 at 13:26 -0800, Stephen Boyd wrote:
> On 02/28, Jerome Brunet wrote:
> > parameter val is not enclosed in parenthesis which is buggy when
> > given an
> > expression instead of a simple value
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Fixes tag? Is there a place in the code that is using a complex
> expression for val right now?
>
Not if with what's already in, afaik. However "clk: meson: mpll: add rw
operation" I sent earlier today uses a ternary operator for val.
That's how I found this issue. Instead of running the test, it would
always use the "else" clause.
I realize I should sent these patches in the same series.
Would you prefer me to do so ?
Jerome
next prev parent reply other threads:[~2017-02-28 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 9:30 [PATCH] clk: meson: fix SET_PARM macro Jerome Brunet
2017-02-28 9:30 ` Jerome Brunet
2017-02-28 18:04 ` Kevin Hilman
2017-02-28 18:04 ` Kevin Hilman
2017-02-28 21:26 ` Stephen Boyd
2017-02-28 21:26 ` Stephen Boyd
2017-02-28 21:41 ` Jerome Brunet [this message]
2017-02-28 21:41 ` Jerome Brunet
2017-03-01 19:03 ` Stephen Boyd
2017-03-01 19:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488318090.21996.2.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.