From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p<foo> extensions
Date: Tue, 28 Feb 2017 16:12:36 -0800 [thread overview]
Message-ID: <1488327156.25838.42.camel@perches.com> (raw)
In-Reply-To: <20170228160607.183a88bd491e97fa6a7ded9c@linux-foundation.org>
On Tue, 2017-02-28 at 16:06 -0800, Andrew Morton wrote:
> On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches <joe@perches.com> wrote:
>
> > %pK was at least once misused at %pk in an out-of-tree module.
> > This lead to some security concerns. Add the ability to track
> > single and multiple line statements for misuses of %p<foo>.
>
> Should we also do this?
>
> --- a/lib/vsprintf.c~checkpatch-add-ability-to-find-bad-uses-of-vsprintf-%pfoo-extensions-fix
> +++ a/lib/vsprintf.c
> @@ -1477,6 +1477,9 @@ int kptr_restrict __read_mostly;
> * by an extra set of alphanumeric characters that are extended format
> * specifiers.
> *
> + * Please update scripts/checkpatch.pl when adding new conversion characters.
> + * (search for "check for vsprintf extension").
> + *
Seems sensible, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p<foo> extensions
Date: Tue, 28 Feb 2017 16:12:36 -0800 [thread overview]
Message-ID: <1488327156.25838.42.camel@perches.com> (raw)
In-Reply-To: <20170228160607.183a88bd491e97fa6a7ded9c@linux-foundation.org>
On Tue, 2017-02-28 at 16:06 -0800, Andrew Morton wrote:
> On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches <joe@perches.com> wrote:
>
> > %pK was at least once misused at %pk in an out-of-tree module.
> > This lead to some security concerns. Add the ability to track
> > single and multiple line statements for misuses of %p<foo>.
>
> Should we also do this?
>
> --- a/lib/vsprintf.c~checkpatch-add-ability-to-find-bad-uses-of-vsprintf-%pfoo-extensions-fix
> +++ a/lib/vsprintf.c
> @@ -1477,6 +1477,9 @@ int kptr_restrict __read_mostly;
> * by an extra set of alphanumeric characters that are extended format
> * specifiers.
> *
> + * Please update scripts/checkpatch.pl when adding new conversion characters.
> + * (search for "check for vsprintf extension").
> + *
Seems sensible, thanks.
next prev parent reply other threads:[~2017-03-01 0:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 19:37 [kernel-hardening] [PATCH] checkpatch: add warning on %pk instead of %pK usage william.c.roberts
2017-02-10 19:37 ` william.c.roberts
2017-02-10 20:12 ` [kernel-hardening] " Joe Perches
2017-02-10 20:12 ` Joe Perches
2017-02-10 22:14 ` [kernel-hardening] " Roberts, William C
2017-02-10 22:14 ` Roberts, William C
2017-02-10 22:26 ` [kernel-hardening] " Roberts, William C
2017-02-10 22:26 ` Roberts, William C
2017-02-10 22:49 ` [kernel-hardening] " Joe Perches
2017-02-10 22:49 ` Joe Perches
2017-02-10 22:59 ` [kernel-hardening] " Joe Perches
2017-02-10 22:59 ` Joe Perches
2017-02-10 23:31 ` [kernel-hardening] " Roberts, William C
2017-02-10 23:31 ` Roberts, William C
2017-02-10 23:49 ` [kernel-hardening] " Joe Perches
2017-02-10 23:49 ` Joe Perches
2017-02-10 23:54 ` [kernel-hardening] " Roberts, William C
2017-02-10 23:54 ` Roberts, William C
2017-02-11 0:01 ` [kernel-hardening] " Joe Perches
2017-02-11 0:01 ` Joe Perches
2017-02-11 1:32 ` [kernel-hardening] " Roberts, William C
2017-02-11 1:32 ` Roberts, William C
2017-02-11 3:23 ` [kernel-hardening] " Joe Perches
2017-02-11 3:23 ` Joe Perches
2017-02-13 19:46 ` [kernel-hardening] " Roberts, William C
2017-02-13 19:46 ` Roberts, William C
2017-02-13 20:14 ` [kernel-hardening] " Joe Perches
2017-02-13 20:14 ` Joe Perches
[not found] ` <1487016251.6214.6.camel@perches.com>
[not found] ` <476DC76E7D1DF2438D32BFADF679FC562305F62F@ORSMSX103.amr.corp.intel.com>
2017-02-13 22:20 ` [kernel-hardening] " Joe Perches
2017-02-13 22:20 ` Joe Perches
2017-02-15 23:49 ` [kernel-hardening] " Roberts, William C
2017-02-15 23:49 ` Roberts, William C
2017-02-16 0:19 ` [kernel-hardening] " Joe Perches
2017-02-16 0:19 ` Joe Perches
2017-02-27 16:26 ` [kernel-hardening] " Roberts, William C
2017-02-27 16:26 ` Roberts, William C
2017-02-27 20:54 ` [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p<foo> extensions Joe Perches
2017-02-27 20:54 ` Joe Perches
2017-02-27 21:18 ` [kernel-hardening] " Kees Cook
2017-02-28 15:34 ` [kernel-hardening] " Roberts, William C
2017-02-28 15:34 ` Roberts, William C
2017-03-01 0:06 ` [kernel-hardening] " Andrew Morton
2017-03-01 0:06 ` Andrew Morton
2017-03-01 0:11 ` [kernel-hardening] " Kees Cook
2017-03-01 1:14 ` Joe Perches
2017-03-01 0:12 ` Joe Perches [this message]
2017-03-01 0:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488327156.25838.42.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.